Add missing comma to metadata example #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I tried copying and pasting this example of gemspec metadata into a gem and noticed that it had a syntax error because there's a missing comma.
simi
approved these changes
Oct 20, 2024
|
Well spotted! Thanks for the update. |
|
Normally we fix this at the source in rubygems/rubygems, and then release scripts bring the changes to this repo, but coincidentially the same fix was already proposed at the source last week, so we're good. Thanks :) |
|
Aha thanks for the context. Sounds good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried copying and pasting this example of gemspec metadata into a gem and noticed that it had a syntax error because there's a missing comma.
From this page: https://guides.rubygems.org/specification-reference/