Remove br tags and css cleanup #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't looked at the code yet, but awesome screenshots! Thanks for reading the instructions and including Actual review coming shortly... |
|
Regarding your note: it sounds like the issue is that you can't see those pages because your account isn't an admin account. You can modify your account locally using the rails console. Try doing this: > me = User.last # or User.find_by(email: <YOUR EMAIL>) if you've made other accounts since.
> me.admin = true
> me.save!You can also use that technique to make yourself a site manager: > me.wishlists << Wishlist.find(<WISHLIST_ID>)Or a normal user again: > me.admin = false
> me.save!Does that help you get to those last |
invacuo
force-pushed
the
ck_remove_more_brs
branch
2 times, most recently
from
42dc93c to
d859aa7
Compare
|
@leesharma Yup, that helped! Before
After
|
leesharma
requested changes
Oct 19, 2017
| color: #fff; | ||
| background-color: #0084ad; | ||
| color: $white; | ||
| background-color: $teal; |
app/views/pledges/edit.html.erb
Outdated
| <%= link_to 'Unpledge item', pledge_path(@pledge), | ||
| method: :delete, | ||
| class: 'text-danger', | ||
| data: { confirm: 'Are you sure you want to unpledge this item?' } %> |
There was a problem hiding this comment.
Could you fix the alignment here?
***Why is this change necessary?*** To remove use of br tags and rely on pure css for margin/ padding ***How does this accomplish the change?*** Used css classes provided by bootstrap to add top and bottom margin in lieu of br tags ***Side effects/ Notes*** I added the same css class to the lead text as well as it was looking too close to the borders or elements above and below it
We're getting an influx of new people, and it'd be nice to give them a
guide for what we're looking for in our PRs. In particular, the
`Resolves #whatever`, WIP label, and explanation of tradeoffs is super
useful for review.
I decided to put this in .github in order to not clutter up the root.
For more info, see this:
https://github.com/blog/2111-issue-and-pull-request-templates
This consolidates GitHub-specific community files into the .github folder. It's nice because it declutters the project root while allowing GitHub to find the appropriate files. I know that CONTRIBUTING is used for more than GitHub, so let me know if you think this really does belong in the root.
Since all routes are being used, there's no need specify all of them.
- [x] Use more meaningful variable names. - [x] Break long lines exceeding 80 characters in new lines.
***What changed?*** - Replaced br tags with divs - Created variables for hex values in variables file and replaced those occurances with the new scss variables ***Notes*** - There are a couple of br tags remaining as pointed below as I could not get to the edit page with my amazon account - https://github.com/invacuo/playtime/blob/master/app/views/wishlists/_form.html.erb#L31 - https://github.com/invacuo/playtime/blob/master/app/views/wishlists/_form.html.erb#L38
invacuo
force-pushed
the
ck_remove_more_brs
branch
from
d859aa7 to
69265a0
Compare
leesharma
approved these changes
Oct 21, 2017
|
Experiment time! I'm going to try rebasing/merging locally and seeing if it closes this PR. Hopefully it works! 🤞 |
|
Aw, no luck. The old-fashioned way then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Notes
Falls under #114
Screenshots
Before
After