Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor views/styles #114

Open
leesharma opened this issue Oct 7, 2017 · 5 comments
Open

Refactor views/styles #114

leesharma opened this issue Oct 7, 2017 · 5 comments

Comments

@leesharma
Copy link
Collaborator

Another open-ended Hacktoberfest issue. 🎃

There are some places where the styles spill into the views or are a little messy (for example, we have some <br />s scattered around). Improving this should make the app a little easier to maintain.

Some examples of fixes in this category:

  • Moving things related to page style/layout (ex. stray <br>s) from the views to the stylesheets
  • Removing redundant/unused styles from the stylesheets
  • Adding helpful comments

If you want to do any major reorganization or make changes to the UI, let us know before you get started. We wouldn't want you to put a lot of effort into something we're not going to merge!

@IanEarley
Copy link

I can take a look at this if you are still wanting someone to help out!

@leesharma
Copy link
Collaborator Author

@IanEarley Sure thing! 😄 Let us know if you have questions or want feedback on what you're doing!

@invacuo
Copy link
Collaborator

invacuo commented Oct 11, 2017

I did some br tag cleanup in #121

@ritarenee15
Copy link

Do you still need anymore help with this?

@leesharma
Copy link
Collaborator Author

@ritarenee15 Definitely! We don't have specific tasks for this one; it's more of a general clean-up issue. If you see something custom that could be expressed with Boostrap classes, messy view code that could be cleaned up, or whatever else, open a PR! 😄

If you want something more concrete, I also just opened an issue relating to a UX bug: #172.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants