4473 expand reminder date possibilities #4606

jlandiseigsti · 2024-08-22T20:58:52Z

Resolves #4473

Description

Replaces Reminder Day with Reminder Schedule. This is a recurring schedule that can occur on alternating months, or send reminders based on days of the week. Anywhere that a Organization or Partner Group could have a reminder day now has a reminder schedule.

Type of change

Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

System tests to walk through the process.
Model tests to ensure the translation from the form to the ical schedule happens correctly.
Validation tests to ensure that bad data doesn't get submitted.

Via db migrations, replaces the simple integer `reminder_day` with the more complex `reminder_schedule` which is an ical string that can be parsed to a repeating Schedule class. Adjusts the logic in the `fetch_partners_to_reminder_now_service` to use the repeating schedule. Updates related tests.

Builds an ActiveModel, ReminderSchedule, which takes the necessary information and turns it into an IceCubeSchedule, which is what ultimate get saved in the db. Builds the form for this reminder schedule. Still needs to conditionally show or hide sections depending on if the user wants date or day of the week.

Now either while creating new Organization/Partner Groups or editing them, all the transfers from Reminder Date to Reminder Day have been made.

This uses css for ease and accessibility.

Adds a number of refactors, including moving all the create_schedule logic to the deadlinable helper, and creates unit and system tests for the new functionality.

Reintroduces the functionality of having warnings for having the reminder date the same as the deadline date.

…r-date-possibilities

We don't want to create a new schedule if nothing has changed, as it will reset the start date and potentially mess with those who have every 2/3/etc months reminders.

…into 4473-expand-reminder-date-possibilities

cielf

Hey @jlandiseigsti. Thank you! I took this out for a manual test spin, and noticed some things that need attention:
1/ I don't think we need the "Send reminders every X months". If they set a reminder date, then it's monthly.
2/ The reminder date doesn't seem to be persisting.
3/ It's not giving an error if I enter a negative date.

Also a question -- would your method allow "last" in the reminder day of the week area?

jlandiseigsti · 2024-09-19T18:04:44Z

Hi, @cielf , I'll get to work addressing those issues.

I believe the ice cube gem allows for "Last"...I'll implement that.

jlandiseigsti · 2024-09-19T18:27:10Z

One product question: if an organization wants to indicate that they want to stop sending reminders, how should they indicate on the edit page? Unlike the Partner Group page, there's not a Send Reminder Checkbox.

jlandiseigsti · 2024-09-19T19:49:26Z

One product question: if an organization wants to indicate that they want to stop sending reminders, how should they indicate on the edit page? Unlike the Partner Group page, there's not a Send Reminder Checkbox.

My assumption is that they either delete the date, if set to "Date", or choose the Blank Option in every Nth Day, if set to "Day of the Wee". But I wanted to confirm that.

jlandiseigsti · 2024-09-19T20:20:16Z

Also, regarding these two corrections:

2/ The reminder date doesn't seem to be persisting.
3/ It's not giving an error if I enter a negative date.

Was the value for Every N Months empty when these happened? That's the only way I was able to recreate the errors (as I had written it that Every N Months blank meant no reminder, and thus no validation/saving.) If so, that's great news, as I'm removing the Every N Months. If there was a value for Every N Months when those bugs occurred, there's something else going on I have to figure out.

All reminders should be Monthly, so every N Months is removed. Also allows users to select "Last" as an option.

cielf · 2024-09-19T23:33:19Z

One product question: if an organization wants to indicate that they want to stop sending reminders, how should they indicate on the edit page? Unlike the Partner Group page, there's not a Send Reminder Checkbox.

My assumption is that they either delete the date, if set to "Date", or choose the Blank Option in every Nth Day, if set to "Day of the Wee". But I wanted to confirm that.

That sounds good as a mechanic to me. It matches up to what they would do now.

cielf · 2024-09-19T23:34:33Z

Also, regarding these two corrections:

2/ The reminder date doesn't seem to be persisting.
3/ It's not giving an error if I enter a negative date.

Was the value for Every N Months empty when these happened? That's the only way I was able to recreate the errors (as I had written it that Every N Months blank meant no reminder, and thus no validation/saving.) If so, that's great news, as I'm removing the Every N Months. If there was a value for Every N Months when those bugs occurred, there's something else going on I have to figure out.

Might have been -- there's a placeholder of 1 and I might have just left it like that.

cielf · 2024-09-23T02:36:11Z

@dorner I'll be doing a final functional check on this in the next couple of days. Please take a technical review pass on it. Thanks.

cielf

For better clarity, can we change "date" to "day of month" throughout for the case where we are picking the nth day of the month, please?

Let's also consistently say "day of the week". Weekday has a different meaning -- i.e. M-F instead of the weekend. [Aside: I would like to find a better term for this, but I haven't yet.]

I haven't yet manually tested whether it is sending out the email appropriately.

cielf · 2024-09-24T12:34:34Z

app/views/shared/_deadline_day_fields.html.erb

-    <%= f.input :reminder_day, wrapper: :input_group, wrapper_html: { class: 'mb-0' },
-                label: 'Reminder day (Day of month an e-mail reminder is sent to partners to submit requests)' do %>
+
+      <%= f.label :date_or_week_day, 'Send reminders on a specific date (eg "the 5th") or a day of the week (eg "the first Tuesday")?' %>


Should be e.g. instead of eg

Rather than "date" and "week_day", we are now using "day_of_month" and "day_of_week" for clarity.

…r-date-possibilities

cielf · 2024-10-04T15:50:57Z

Hey @jlandiseigsti Found an unexpected result...

If you have a deadline day of the 1st.
Then you click Day of Month and put 1 in the reminder date, you get an error, "Reminder day cannot be the same as deadline day." Which is fine.
But if you then click Day of the Week, and set the Reminder Day of the Week to Second Sunday, you still have the error (see below)

(Edit: I went in and cleared the reminder day and it still wouldn't clear the error)

There was a bug in which if the reminder day of the month was the same as the deadline day, it would dislplay the error message even if the user changed to the day of the week option. Now the error message is hidden if the user is selecting the day of the week option.

cielf

Hey @jlandiseigsti -- that behaviour works now -- Thanks!

I noticed something I missed on the earlier go-throughs, though.

When we pick a Day of Month and select the day, we are informed of when the next reminder will be sent. I'm not seeing that message when we pick a Day of the Week.

Could you address that, please? Thanks.

ps - the typo is still there.

cielf · 2024-10-31T11:34:16Z

Hey @jlandiseigsti -- are you still working on this, or shall we see if we can get someone else to finish up?

jlandiseigsti · 2024-10-31T14:32:12Z

Hey @jlandiseigsti -- are you still working on this, or shall we see if we can get someone else to finish up?

Hi @cielf – I think it would be best if I handed it off right now. Life's gotten kind of hectic and I'm not sure when I'll be able to devote the time to finishing it.

cielf · 2024-10-31T19:11:29Z

@jlandiseigsti Ok, I'l mark it "Help Wanted", pointing to this PR. If no one picks it up, please feel free to continue with it if things get calmer.

jlandiseigsti and others added 9 commits July 22, 2024 08:34

Adds Reminder Schedule fields to New and Edit Organization

409209d

Now either while creating new Organization/Partner Groups or editing them, all the transfers from Reminder Date to Reminder Day have been made.

Makes the day of week or date hide depending on selection

03cd829

This uses css for ease and accessibility.

Adds tests and does refactoring

80f6c02

Adds a number of refactors, including moving all the create_schedule logic to the deadlinable helper, and creates unit and system tests for the new functionality.

4473 - Makes same warning appear for reminder date

8b2524a

Reintroduces the functionality of having warnings for having the reminder date the same as the deadline date.

Merge remote-tracking branch 'upstream/main' into 4473-expand-reminde…

64f7499

…r-date-possibilities

Merge branch 'main' into 4473-expand-reminder-date-possibilities

93cdebc

Only create new schedule if details have changed

bea7a03

We don't want to create a new schedule if nothing has changed, as it will reset the start date and potentially mess with those who have every 2/3/etc months reminders.

jlandiseigsti force-pushed the 4473-expand-reminder-date-possibilities branch 2 times, most recently from acba202 to aa3e2f5 Compare September 16, 2024 20:11

Merge branch 'main' of https://github.com/rubyforgood/human-essentials …

044e6bf

…into 4473-expand-reminder-date-possibilities

jlandiseigsti force-pushed the 4473-expand-reminder-date-possibilities branch from aa3e2f5 to 044e6bf Compare September 16, 2024 20:14

jlandiseigsti marked this pull request as ready for review September 16, 2024 20:19

cielf self-requested a review September 19, 2024 16:20

cielf requested changes Sep 19, 2024

View reviewed changes

4473 - Removes Every N Months

a0d1a65

All reminders should be Monthly, so every N Months is removed. Also allows users to select "Last" as an option.

jlandiseigsti requested a review from cielf September 20, 2024 14:19

cielf requested a review from dorner September 23, 2024 02:36

cielf requested changes Sep 24, 2024

View reviewed changes

jlandiseigsti added 2 commits October 2, 2024 10:04

4473 - Updates names of Month vs Week fields

a14719c

Rather than "date" and "week_day", we are now using "day_of_month" and "day_of_week" for clarity.

Merge remote-tracking branch 'upstream/main' into 4473-expand-reminde…

9a5a757

…r-date-possibilities

jlandiseigsti force-pushed the 4473-expand-reminder-date-possibilities branch from dfb4069 to 9a5a757 Compare October 2, 2024 19:23

This comment was marked as duplicate.

Sign in to view

cielf requested changes Oct 7, 2024

View reviewed changes

cielf mentioned this pull request Oct 31, 2024

Expand possible dates for reminder emails #4473

Open

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

4473 expand reminder date possibilities #4606

4473 expand reminder date possibilities #4606

jlandiseigsti commented Aug 22, 2024 •

edited

Loading

cielf left a comment •

edited

Loading

jlandiseigsti commented Sep 19, 2024

jlandiseigsti commented Sep 19, 2024

jlandiseigsti commented Sep 19, 2024 •

edited

Loading

jlandiseigsti commented Sep 19, 2024

cielf commented Sep 19, 2024

cielf commented Sep 19, 2024

cielf commented Sep 23, 2024

cielf left a comment

cielf Sep 24, 2024

cielf commented Oct 4, 2024 •

edited

Loading

This comment was marked as duplicate.

cielf left a comment

cielf commented Oct 31, 2024

jlandiseigsti commented Oct 31, 2024

cielf commented Oct 31, 2024

4473 expand reminder date possibilities #4606

Are you sure you want to change the base?

4473 expand reminder date possibilities #4606

Conversation

jlandiseigsti commented Aug 22, 2024 • edited Loading

Description

Type of change

How Has This Been Tested?

cielf left a comment • edited Loading

Choose a reason for hiding this comment

jlandiseigsti commented Sep 19, 2024

jlandiseigsti commented Sep 19, 2024

jlandiseigsti commented Sep 19, 2024 • edited Loading

jlandiseigsti commented Sep 19, 2024

cielf commented Sep 19, 2024

cielf commented Sep 19, 2024

cielf commented Sep 23, 2024

cielf left a comment

Choose a reason for hiding this comment

cielf Sep 24, 2024

Choose a reason for hiding this comment

cielf commented Oct 4, 2024 • edited Loading

This comment was marked as duplicate.

cielf left a comment

Choose a reason for hiding this comment

cielf commented Oct 31, 2024

jlandiseigsti commented Oct 31, 2024

cielf commented Oct 31, 2024

jlandiseigsti commented Aug 22, 2024 •

edited

Loading

cielf left a comment •

edited

Loading

jlandiseigsti commented Sep 19, 2024 •

edited

Loading

cielf commented Oct 4, 2024 •

edited

Loading