Skip to content

Commit

Permalink
Seems like bundler respects the .gem file name
Browse files Browse the repository at this point in the history
  • Loading branch information
kateinoigakukun committed Jul 19, 2024
1 parent 54742bc commit 0b66668
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions packages/npm-packages/ruby-head-wasm-wasi/Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@

source "https://rubygems.org"

# We build ./vendor/cache/js-local.gem just before evaluating this Gemfile
# We build ./vendor/cache/js-{version}.gem just before evaluating this Gemfile
# so that Bundler builds extensions even from the local gem. (gem extensions
# from "path:" gems are not built by Bundler.)
# Thus even we specify version of "js" gem here, it should always installed
# from the ./vendor/cache/js-local.gem, not from rubygems.org. To achieve this,
# from the ./vendor/cache/js-{version}.gem, not from rubygems.org. To achieve this,
# we always use non-exist version during development.
require_relative "../../gems/js/lib/js/version.rb"
gem "js", JS::VERSION
Expand Down
2 changes: 1 addition & 1 deletion rakelib/packaging.rake
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ def vendor_gem_cache(pkg)
mkdir_p vendor_cache_dir
require_relative "../packages/gems/js/lib/js/version"
sh "gem", "-C", "packages/gems/js", "build", "-o",
File.join(vendor_cache_dir, "js-local.gem")
File.join(vendor_cache_dir, "js-#{JS::VERSION}.gem")
end

namespace :npm do
Expand Down

0 comments on commit 0b66668

Please sign in to comment.