Allow composing user-defined WINCH signal traps #736
Conversation
Resolves ruby#735 Just as the `handle_interrupted` method runs Reline's interrupt hook logic and then runs any user-defined interrupt hook logic, `handle_resized` should run Reline's resize hook logic and then run any user-defined resize logic. This allows user CLI's with additional content in addition to the Reline prompt to ensure that additional content is rendered properly as the terminal is resized. Note: This is my best first attempt at this solution as someone who has only read the source code here today. There may be details/considerations that are important that I missed or didn't consider. I am very open to changes as necessary. cc: @st0012
| end | ||
| end | ||
|
|
||
| def set_signal_handlers | ||
| Reline::IOGate.set_winch_handler do | ||
| @old_winch_trap = Reline::IOGate.set_winch_handler do |
There was a problem hiding this comment.
Reline::IOGate.set_winch_handler does not return old_winch_trap.
Reline::ANSI returns SIGCONT trap
Reline::Windows returns new_winch_trap
Reline::Dumb returns nil
I think we should do old_winch_trap.call inside lib/reline/io/ansi.rb.
def set_winch_handler(&handler)
@old_winch_handler = Signal.trap('WINCH') do
# do it here?
end
@old_cont_handler = Signal.trap('CONT') do
# maybe we can fix the same problem with SIGCONT here
end
endThere was a problem hiding this comment.
Ah, great point. I've only been using the ANSI adapter, so didn't think to check the others and what they return. Will think on how to shift this down one level
| case @old_winch_trap | ||
| when 'DEFAULT', 'SYSTEM_DEFAULT', 'IGNORE' | ||
| # Do nothing | ||
| when 'EXIT' | ||
| exit | ||
| else | ||
| @old_winch_trap.call if @old_winch_trap.respond_to?(:call) | ||
| end |
There was a problem hiding this comment.
I think @old_winch_trap.call if @old_winch_trap.respond_to?(:call) is enough.
I don't think Signal.trap('WINCH', 'EXIT') will be used. Even if it is set, we can think that Reline override and ignore it.
We can consider adding when 'EXIT'; exit when there is a request with a use case.
Resolves #735
Just as the
handle_interruptedmethod runs Reline's interrupt hook logic and then runs any user-defined interrupt hook logic,handle_resizedshould run Reline's resize hook logic and then run any user-defined resize logic.This allows user CLI's with additional content in addition to the Reline prompt to ensure that additional content is rendered properly as the terminal is resized.
Note: This is my best first attempt at this solution as someone who has only read the source code here today. There may be details/considerations that are important that I missed or didn't consider. I am very open to changes as necessary.
cc: @st0012