Set time directly on the x509 store #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segiddins
force-pushed
the
segiddins/set-time-directly-on-the-x509-store
branch
from
b4ae6c4
to
dca2ee8
Compare
woodruffw
reviewed
Jun 25, 2024
segiddins
force-pushed
the
segiddins/set-time-directly-on-the-x509-store
branch
2 times, most recently
from
a508d5c
to
2679889
Compare
segiddins
added a commit
to sigstore/sigstore-ruby
that referenced
this pull request
Jun 26, 2024
Depends on ruby/openssl#770
|
Unsure why that one build failed, @rhenium mind restarting it? Everything was green earlier |
woodruffw
reviewed
Jun 26, 2024
rhenium
reviewed
Jun 27, 2024
rhenium
reviewed
Jun 27, 2024
Instead of an ivar, so other ossl functions that take a store will use the correct time when verifying
segiddins
force-pushed
the
segiddins/set-time-directly-on-the-x509-store
branch
from
2679889
to
69c57f6
Compare
|
@rhenium done! |
segiddins
added a commit
to sigstore/sigstore-ruby
that referenced
this pull request
Jun 27, 2024
Depends on ruby/openssl#770 Signed-off-by: Samuel Giddins <[email protected]>
segiddins
added a commit
to sigstore/sigstore-ruby
that referenced
this pull request
Jun 28, 2024
Depends on ruby/openssl#770 Signed-off-by: Samuel Giddins <[email protected]>
segiddins
added a commit
to sigstore/sigstore-ruby
that referenced
this pull request
Jun 28, 2024
Depends on ruby/openssl#770 Signed-off-by: Samuel Giddins <[email protected]>
rhenium
reviewed
Jul 3, 2024
segiddins
commented
Jul 3, 2024
|
@rhenium should be ready to merge! |
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Jul 24, 2024
(ruby/openssl#770) Instead of an ivar, so other ossl functions that take a store will use the correct time when verifying ruby/openssl@21aadc66ae
|
Yes, it looks good to me. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of an ivar, so other ossl functions that take a store (such as
OpenSSL::Timestamp::Response#verify) will use the correct time when verifying