Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Returns keysize in bits #691

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Returns keysize in bits #691

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
14db821
Adding utility to return the actual bit size of the key. Especially n…
Antrapol Oct 29, 2023
7ff3737
Reformat the source code and create new test cases for keysize_in_bits
Antrapol Nov 13, 2023
b92ee8b
Missed one place to in test case ec
Antrapol Nov 13, 2023
0b3fe97
Seems the reporting of keysize is not consistent across different Ope…
Antrapol Nov 14, 2023
370b2f1
Add condition to test keysize in bits since OpenSSL version 1.1.1 ret…
Antrapol Nov 14, 2023
fb17bc9
Tested local seems ed25519 also returned 253 as bit size
Antrapol Nov 14, 2023
db2ac8a
Not getting consistance result on ED25519 keysize
Antrapol Nov 15, 2023
5ce7e11
Change name to bits instead of keysize_in_bits and remove some additi…
Antrapol Nov 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions ext/openssl/ossl_pkey.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1666,6 +1666,23 @@ ossl_pkey_decrypt(int argc, VALUE *argv, VALUE self)
return str;
}


/*
* Returns bit length of the PKEy
chrisliaw marked this conversation as resolved.
Show resolved Hide resolved
*/
static VALUE
ossl_pkey_length_in_bits(VALUE self)
{
EVP_PKEY * pkey;
int bits;

GetPKey(self, pkey);

bits = EVP_PKEY_get_bits(pkey);
return INT2NUM(bits);

}

chrisliaw marked this conversation as resolved.
Show resolved Hide resolved
/*
* INIT
*/
Expand Down Expand Up @@ -1785,6 +1802,9 @@ Init_ossl_pkey(void)
rb_define_method(cPKey, "encrypt", ossl_pkey_encrypt, -1);
rb_define_method(cPKey, "decrypt", ossl_pkey_decrypt, -1);


rb_define_method(cPKey, "keysize_in_bits", ossl_pkey_length_in_bits, 0);
chrisliaw marked this conversation as resolved.
Show resolved Hide resolved

id_private_q = rb_intern("private?");

/*
Expand Down
1 change: 1 addition & 0 deletions test/openssl/test_pkey.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ def test_generic_oid_inspect
assert_instance_of OpenSSL::PKey::PKey, x25519
assert_equal "X25519", x25519.oid
assert_match %r{oid=X25519}, x25519.inspect
assert_equal 253, x25519.keysize_in_bits
chrisliaw marked this conversation as resolved.
Show resolved Hide resolved
end

def test_s_generate_parameters
Expand Down
3 changes: 3 additions & 0 deletions test/openssl/test_pkey_dh.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@ def test_derive_key
assert_equal z, dh1.derive(dh2_pub)
assert_equal z, dh2.derive(dh1_pub)

assert_equal(1024, dh1.keysize_in_bits)
assert_equal(1024, dh2.keysize_in_bits)
chrisliaw marked this conversation as resolved.
Show resolved Hide resolved

assert_raise(OpenSSL::PKey::PKeyError) { params.derive(dh1_pub) }
assert_raise(OpenSSL::PKey::PKeyError) { dh1_pub.derive(params) }

Expand Down
3 changes: 3 additions & 0 deletions test/openssl/test_pkey_ec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,16 +76,19 @@ def test_check_key
assert_equal(true, key0.check_key)
assert_equal(true, key0.private?)
assert_equal(true, key0.public?)
assert_equal(256, key0.keysize_in_bits)
chrisliaw marked this conversation as resolved.
Show resolved Hide resolved

key1 = OpenSSL::PKey.read(key0.public_to_der)
assert_equal(true, key1.check_key)
assert_equal(false, key1.private?)
assert_equal(true, key1.public?)
assert_equal(256, key1.keysize_in_bits)

key2 = OpenSSL::PKey.read(key0.private_to_der)
assert_equal(true, key2.private?)
assert_equal(true, key2.public?)
assert_equal(true, key2.check_key)
assert_equal(256, key2.keysize_in_bits)

# Behavior of EVP_PKEY_public_check changes between OpenSSL 1.1.1 and 3.0
key4 = Fixtures.pkey("p256_too_large")
Expand Down
Loading