Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ Fix GH action for rubygems Trusted Publishing #340

Merged
merged 1 commit into from
Oct 13, 2024

Conversation

nevans
Copy link
Collaborator

@nevans nevans commented Oct 13, 2024

I'm not sure why dependabot didn't suggest upgrading these. But we need to consider these actions as trustworthy, so I think that any security risk due to using a version branch (rather than a checksum) is offset by the hassle (and security risk!) of not automatically getting updates.

In particular, even if dependabot did make PRs to upgrade these, it wouldn't have made a PR for the v0.4-stable branch.

I'm not sure why dependabot didn't suggest upgrading these.  But we need
to consider these actions as trustworthy, so I think that any security
risk due to using a version branch (rather than a checksum) is offset by
the hassle (and security risk!) of not automatically getting updates.

In particular, even if dependabot _did_ make PRs to upgrade these, it
wouldn't have made a PR for the `v0.4-stable` branch.
@nevans nevans merged commit 3e77349 into master Oct 13, 2024
22 checks passed
@nevans nevans deleted the fix-gh-workflow-push_gem branch October 13, 2024 19:18
nevans added a commit that referenced this pull request Oct 13, 2024
…push_gem

✅ Fix GH action for rubygems Trusted Publishing (backport: #340)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant