Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🥅 Improve SequenceSet frozen errors [backport: #331] #338

Merged
merged 1 commit into from
Oct 13, 2024
Merged

🥅 Improve SequenceSet frozen errors [backport: #331] #338

merged 1 commit into from
Oct 13, 2024

Commits on Oct 13, 2024

  1. 🥅 Improve SequenceSet frozen errors 

    Previously, SequenceSet modification methods would raise a frozen error
when it updated its internal data structure (currently implemented as an
array of arrays), which was "can't modify frozen Array: [int, int]".
This was unexpected, confusing, and misleading.

This changes the SequenceSet modification methods to raise the expected
FrozenError _prior_ to attempting to modify the internal data structure.
    @nevans
    nevans committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    0bb92a4 View commit details
    Browse the repository at this point in the history