Make the RDF::Repository more symmetric on insert/delete and right with RDF::Statement usage. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 19, 2016 15:21
The delete operation now initialize the context of statements with the context uri when a context is set on the RDF Repository.
|
Note that "context" has been obsoleted in RDF.rb 2.0 in favor of "graph_name", along with many other changes that may affect this gem. |
|
Yes, thanks for the heads up. I plan to implement a large PR for this gem, upgrading it to suit RDF.rb 2.0. (All the DEPRECATION messages coming from this gem ruin my logs. 😄 ) This PR is the first milestone, another one improving tests will come in the following days, setting the scene for the gem update. |
|
@kbogtob : see Sesame API 2.7 Documentation. context can accept multiple values so the PR needs to be updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RDF::Statement can only have one context at a time so it's no use to keep an Enumerable of contexts to assign to statements on insert and delete operations.
Moreover, the insert and the delete operations are not symmetric. I've opened the issue #11 about that problem. This PR fixes that behavior.
Edit: grammar