Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the spec under spec/issues for the issue id 730 #735

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

bhaskarshankarling
Copy link

Added the spec to check the issue #730 related to swagger doc not getting generated when one grape API app is mounted in another grape API app.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.213% when pulling c484adb on bhaskarshankarling:spec_for_the_issue_730 into 02ede02 on ruby-grape:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.213% when pulling c484adb on bhaskarshankarling:spec_for_the_issue_730 into 02ede02 on ruby-grape:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.213% when pulling c484adb on bhaskarshankarling:spec_for_the_issue_730 into 02ede02 on ruby-grape:master.

@coveralls
Copy link

coveralls commented Dec 19, 2018

Coverage Status

Coverage remained the same at 99.319% when pulling e86b2f4 on bhaskarshankarling:spec_for_the_issue_730 into d20b910 on ruby-grape:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.213% when pulling c484adb on bhaskarshankarling:spec_for_the_issue_730 into 02ede02 on ruby-grape:master.

@grape-bot
Copy link

grape-bot commented Dec 19, 2018

1 Warning
⚠️ Unless you’re refactoring existing code, please update CHANGELOG.md.
1 Message
📖 We really appreciate pull requests that demonstrate issues, even without a fix. That said, the next step is to try and fix the failing tests!

Here's an example of a CHANGELOG.md entry:

* [#735](https://github.com/ruby-grape/grape-swagger/pull/735): Added the spec under spec/issues for the issue id 730 - [@bhaskarshankarling](https://github.com/bhaskarshankarling).

Generated by 🚫 danger

@LeFnord
Copy link
Member

LeFnord commented Dec 19, 2018

mmh … shouldn't it be fail?

@bhaskarshankarling
Copy link
Author

mmh … shouldn't it be fail?

Yes, I am also wondering why it passed. Since I am new to CI and everything, I thought it is showing green only for removing offences pointed out by rubocop. The second spec is still failing at my local.

@bhaskarshankarling
Copy link
Author

bhaskarshankarling commented Dec 20, 2018

mmh … shouldn't it be fail?

#735 (comment). What about this previous comment generated by bot, it says that it appreciates the failing spec, that means the spec is failing.

@bhaskarshankarling
Copy link
Author

mmh … shouldn't it be fail?

Please let me know if I have done anything wrong in the specs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants