Fix Rails/CompactBlank
to avoid reporting offense for filter
in Ruby versions below 2.6
#1361
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
Rails/CompactBlank
to avoid reporting offense forfilter
in Ruby versions below 2.6.This change is related to #1359. Apologies for the confusion earlier, as I initially mixed up the runtime version with the analysis version when considering Rubocop's supported versions.
Rails/CompactBlank
applies to Rails 6.1 and above, where the required Ruby version is 2.5. However, sincefilter
method was introduced in Ruby 2.6, usingfilter
in environments running Ruby 2.5 may result in false positives.Additionally, since #1359 is still unreleased, I am unsure whether this change should be added to the changelog. I would appreciate any feedback, including thoughts on other aspects of this PR.
Before submitting the PR make sure the following are checked:
* [ ] Commit message starts with[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.* [] If this is a new cop, consider making a corresponding update to the [Rails Style Guide](https://github.com/rubocop/rails-style-guide).