Merge pull request Expensify#39979 from Expensify/hayata-fix-issue-wi…

…th-reliable-update

Check if the OpenApp has finished or not before updating Onyx data

src/libs/actions/OnyxUpdateManager.ts

@@ -28,12 +28,24 @@ Onyx.connect({
     callback: (value) => (lastUpdateIDAppliedToClient = value),
 });
 
+let isLoadingApp = false;
+Onyx.connect({
+    key: ONYXKEYS.IS_LOADING_APP,
+    callback: (value) => {
+        isLoadingApp = value ?? false;
+    },
+});
+
 export default () => {
     console.debug('[OnyxUpdateManager] Listening for updates from the server');
     Onyx.connect({
         key: ONYXKEYS.ONYX_UPDATES_FROM_SERVER,
         callback: (value) => {
-            if (!value) {
+            // When the OpenApp command hasn't finished yet, we should not process any updates.
+            if (!value || isLoadingApp) {
+                if (isLoadingApp) {
+                    console.debug(`[OnyxUpdateManager] Ignoring Onyx updates while OpenApp hans't finished yet.`);
+                }
                 return;
             }
             // This key is shared across clients, thus every client/tab will have a copy and try to execute this method.