Skip to content

Commit

Permalink
Merge pull request #28 from rubberduck203/27-fix-help-text
Browse files Browse the repository at this point in the history
Fixes #27: Disable nullable reference types for options class
  • Loading branch information
rubberduck203 authored Nov 23, 2020
2 parents 116f2b9 + 4d2dbbf commit 414e9e8
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 6 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ Symoblic linking to a location already on the PATH (like `/usr/local/bin/`) is r
```bash
# Download release (replace version and runtime accordingly)
cd ~/Downloads
wget https://github.com/rubberduck203/GitNStats/releases/download/2.3.0/osx-x64.zip
wget https://github.com/rubberduck203/GitNStats/releases/download/2.3.1/osx-x64.zip

# Create directory to keep package
mkdir -p ~/bin/gitnstats
Expand Down
2 changes: 1 addition & 1 deletion appveyor.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
version: 2.3.0.{build}
version: 2.3.1.{build}
pull_requests:
do_not_increment_build_number: true
image: Visual Studio 2019 Preview
Expand Down
9 changes: 6 additions & 3 deletions src/gitnstats/Options.cs
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
using System;
// re-enable when https://github.com/commandlineparser/commandline/pull/715 is merged & released
#nullable disable

using System;
using System.Collections.Generic;
using CommandLine;
using CommandLine.Text;
Expand All @@ -10,10 +13,10 @@ public class Options
private const string RepoPathHelpText = "Path to the git repository to be analyzed. Defaults to the current working directory.";

[Value(1, HelpText = RepoPathHelpText, MetaName = "FilePath")]
public string? RepositoryPath { get; set; }
public string RepositoryPath { get; set; }

[Option('b', "branch", HelpText = "Defaults to the currently active branch.")]
public string? BranchName { get; set; }
public string BranchName { get; set; }

[Option('d', "date-filter", HelpText = "Get commits on or after this date. Defaults to no filter.")]
public DateTime? DateFilter { get; set; }
Expand Down
2 changes: 1 addition & 1 deletion src/gitnstats/gitnstats.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net5.0</TargetFramework>
<Version>2.3.0</Version>
<Version>2.3.1</Version>
<PublishTrimmed>true</PublishTrimmed>
<RuntimeIdentifiers>osx-x64;linux-x64;win10-x64</RuntimeIdentifiers>
<Nullable>enable</Nullable>
Expand Down

0 comments on commit 414e9e8

Please sign in to comment.