Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Misleading tooltip #2098

Merged
merged 2 commits into from
Oct 10, 2024
Merged

fix: Misleading tooltip #2098

merged 2 commits into from
Oct 10, 2024

Conversation

MagnusHafstad
Copy link
Contributor

Changes

Look at the issue. This PR fixes it

-#2070

@MagnusHafstad MagnusHafstad added the bug Something isn't working label Oct 7, 2024
Copy link

vercel bot commented Oct 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
indok-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 4:06pm

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.28%. Comparing base (7e34142) to head (70d60f4).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2098   +/-   ##
=======================================
  Coverage   83.28%   83.28%           
=======================================
  Files         100      100           
  Lines        3572     3572           
=======================================
  Hits         2975     2975           
  Misses        597      597           
Flag Coverage Δ
apitests 83.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Oct 7, 2024

Indøk Web    Run #3316

Run Properties:  status check passed Passed #3316  •  git commit 9f9d6b0a21 ℹ️: Merge 70d60f479ff724f75f2e7753ec9fc25f16d574f4 into 7e34142d05f32cbf719e153d737f...
Project Indøk Web
Branch Review fix-tooltip
Run status status check passed Passed #3316
Run duration 01m 39s
Commit git commit 9f9d6b0a21 ℹ️: Merge 70d60f479ff724f75f2e7753ec9fc25f16d574f4 into 7e34142d05f32cbf719e153d737f...
Committer MagnusHafstad
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 2
View all changes introduced in this branch ↗︎

Copy link

sonarcloud bot commented Oct 7, 2024

Copy link
Contributor

@torgeirlysen torgeirlysen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@torgeirlysen torgeirlysen merged commit 1993cc0 into main Oct 10, 2024
21 checks passed
@torgeirlysen torgeirlysen deleted the fix-tooltip branch October 10, 2024 14:29
Copy link

cypress bot commented Oct 10, 2024

Indøk Web    Run #3324

Run Properties:  status check passed Passed #3324  •  git commit 1993cc07d9: fix: Misleading tooltip (#2098)
Project Indøk Web
Run status status check passed Passed #3324
Run duration 01m 35s
Commit git commit 1993cc07d9: fix: Misleading tooltip (#2098)
Committer Torgeir Lysen
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants