Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat(members): add by email #553

Merged
merged 3 commits into from
Mar 15, 2024
Merged

✨ feat(members): add by email #553

merged 3 commits into from
Mar 15, 2024

Conversation

larwaa
Copy link
Member

@larwaa larwaa commented Mar 15, 2024

Changes

  • Make it possible to add users to organizations by their email
  • More lenient CORS headers for blob storage

Copy link

github-actions bot commented Mar 15, 2024

Planned Changes to Server Infrastructure

Terraform Format and Style 🖌 success

Terraform Initialization ⚙️ success

Terraform Plan 📖 success

Terraform Validation 🤖 success

Show Plan
module.server.random_password.password: Refreshing state... [id=none]
module.server.random_password.session_secret_value: Refreshing state... [id=none]
random_string.resource_code: Refreshing state... [id=7o8xwaka]
github_repository_environment.this: Refreshing state... [id=indok-api:production]
module.server.data.azurerm_client_config.current: Reading...
module.server.data.azurerm_key_vault_secret.postmark_api_token: Reading...
module.server.data.azurerm_key_vault_secret.feide_client_secret: Reading...
data.azurerm_client_config.current: Reading...
module.server.module.resource_group.azurerm_resource_group.this: Refreshing state... [id=/subscriptions/0f6b5c8e-cc15-4af4-ba60-40aa8301955e/resourceGroups/rg-7o8xwaka]
data.azurerm_client_config.current: Read complete after 0s [id=Y2xpZW50Q29uZmlncy9jbGllbnRJZD00MmJiMGZiYS0wZmIyLTRjZWItYmRiZi1jNmNjNmFmZTI1MDY7b2JqZWN0SWQ9Y2IxNTc2YmItMjYxOC00NWEwLTgzNjMtMDU3NWQ3ZTdlNDEyO3N1YnNjcmlwdGlvbklkPTBmNmI1YzhlLWNjMTUtNGFmNC1iYTYwLTQwYWE4MzAxOTU1ZTt0ZW5hbnRJZD1mMTdhY2Y1Ni1hYjEzLTQzZmEtYjlkNy1mMGUwZDYyODMyNmM=]
module.server.data.azurerm_client_config.current: Read complete after 0s [id=Y2xpZW50Q29uZmlncy9jbGllbnRJZD00MmJiMGZiYS0wZmIyLTRjZWItYmRiZi1jNmNjNmFmZTI1MDY7b2JqZWN0SWQ9Y2IxNTc2YmItMjYxOC00NWEwLTgzNjMtMDU3NWQ3ZTdlNDEyO3N1YnNjcmlwdGlvbklkPTBmNmI1YzhlLWNjMTUtNGFmNC1iYTYwLTQwYWE4MzAxOTU1ZTt0ZW5hbnRJZD1mMTdhY2Y1Ni1hYjEzLTQzZmEtYjlkNy1mMGUwZDYyODMyNmM=]
module.server.module.managed_identity.azurerm_user_assigned_identity.this: Refreshing state... [id=/subscriptions/0f6b5c8e-cc15-4af4-ba60-40aa8301955e/resourceGroups/rg-7o8xwaka/providers/Microsoft.ManagedIdentity/userAssignedIdentities/managed-identity-7o8xwaka]
module.server.module.container_app_environment.azurerm_log_analytics_workspace.this: Refreshing state... [id=/subscriptions/0f6b5c8e-cc15-4af4-ba60-40aa8301955e/resourceGroups/rg-7o8xwaka/providers/Microsoft.OperationalInsights/workspaces/ca-log-workspace-7o8xwaka]
module.server.module.vnet.azurerm_virtual_network.this: Refreshing state... [id=/subscriptions/0f6b5c8e-cc15-4af4-ba60-40aa8301955e/resourceGroups/rg-7o8xwaka/providers/Microsoft.Network/virtualNetworks/vnet-7o8xwaka]
module.server.module.database.azurerm_private_dns_zone.this: Refreshing state... [id=/subscriptions/0f6b5c8e-cc15-4af4-ba60-40aa8301955e/resourceGroups/rg-7o8xwaka/providers/Microsoft.Network/privateDnsZones/production-7o8xwaka.postgres.database.azure.com]
module.server.module.redis.azurerm_private_dns_zone.this: Refreshing state... [id=/subscriptions/0f6b5c8e-cc15-4af4-ba60-40aa8301955e/resourceGroups/rg-7o8xwaka/providers/Microsoft.Network/privateDnsZones/privatelink.redis.cache.windows.net]
module.server.module.redis.azurerm_redis_cache.this: Refreshing state... [id=/subscriptions/0f6b5c8e-cc15-4af4-ba60-40aa8301955e/resourceGroups/rg-7o8xwaka/providers/Microsoft.Cache/redis/redis7o8xwaka]
module.server.module.container_app_environment.azurerm_subnet.this: Refreshing state... [id=/subscriptions/0f6b5c8e-cc15-4af4-ba60-40aa8301955e/resourceGroups/rg-7o8xwaka/providers/Microsoft.Network/virtualNetworks/vnet-7o8xwaka/subnets/ca-subnet-7o8xwaka]
module.server.module.redis.azurerm_subnet.this: Refreshing state... [id=/subscriptions/0f6b5c8e-cc15-4af4-ba60-40aa8301955e/resourceGroups/rg-7o8xwaka/providers/Microsoft.Network/virtualNetworks/vnet-7o8xwaka/subnets/redis-subnet-7o8xwaka]
module.server.module.database.azurerm_subnet.this: Refreshing state... [id=/subscriptions/0f6b5c8e-cc15-4af4-ba60-40aa8301955e/resourceGroups/rg-7o8xwaka/providers/Microsoft.Network/virtualNetworks/vnet-7o8xwaka/subnets/pg-subnet-7o8xwaka]
module.server.azurerm_role_assignment.key_vault_user: Refreshing state... [id=/subscriptions/0f6b5c8e-cc15-4af4-ba60-40aa8301955e/resourceGroups/rg-7o8xwaka/providers/Microsoft.Authorization/roleAssignments/3f3dc4d0-bea7-e10e-7ed4-2495fd459a06]
module.server.azurerm_role_assignment.rg_reader: Refreshing state... [id=/subscriptions/0f6b5c8e-cc15-4af4-ba60-40aa8301955e/resourceGroups/rg-7o8xwaka/providers/Microsoft.Authorization/roleAssignments/dfd26610-34ca-2698-65fb-50110851658a]
module.server.module.blob_storage.azurerm_storage_account.main: Refreshing state... [id=/subscriptions/0f6b5c8e-cc15-4af4-ba60-40aa8301955e/resourceGroups/rg-7o8xwaka/providers/Microsoft.Storage/storageAccounts/appstore7o8xwaka]
module.server.module.key_vault.azurerm_key_vault.this: Refreshing state... [id=/subscriptions/0f6b5c8e-cc15-4af4-ba60-40aa8301955e/resourceGroups/rg-7o8xwaka/providers/Microsoft.KeyVault/vaults/key-vault-7o8xwaka]
module.server.module.redis.azurerm_private_dns_zone_virtual_network_link.this: Refreshing state... [id=/subscriptions/0f6b5c8e-cc15-4af4-ba60-40aa8301955e/resourceGroups/rg-7o8xwaka/providers/Microsoft.Network/privateDnsZones/privatelink.redis.cache.windows.net/virtualNetworkLinks/vnet-private-zone-link]
module.server.module.database.azurerm_private_dns_zone_virtual_network_link.this: Refreshing state... [id=/subscriptions/0f6b5c8e-cc15-4af4-ba60-40aa8301955e/resourceGroups/rg-7o8xwaka/providers/Microsoft.Network/privateDnsZones/production-7o8xwaka.postgres.database.azure.com/virtualNetworkLinks/pg-7o8xwaka.com]
module.server.data.azurerm_key_vault_secret.feide_client_secret: Read complete after 3s [id=https://shared-key-vault-altht.vault.azure.net/secrets/feide-client-secret/299f08ebe57941dda63f30a792037af0]
module.server.data.azurerm_key_vault_secret.postmark_api_token: Read complete after 3s [id=https://shared-key-vault-altht.vault.azure.net/secrets/postmark-api-token/fb5215c57cd64a349554c5830934b085]
module.server.module.database.azurerm_postgresql_flexible_server.this: Refreshing state... [id=/subscriptions/0f6b5c8e-cc15-4af4-ba60-40aa8301955e/resourceGroups/rg-7o8xwaka/providers/Microsoft.DBforPostgreSQL/flexibleServers/pg-fs-7o8xwaka]
module.server.module.container_app_environment.azurerm_container_app_environment.this: Refreshing state... [id=/subscriptions/0f6b5c8e-cc15-4af4-ba60-40aa8301955e/resourceGroups/rg-7o8xwaka/providers/Microsoft.App/managedEnvironments/ca-env-7o8xwaka]
module.server.module.database.azurerm_postgresql_flexible_server_database.this: Refreshing state... [id=/subscriptions/0f6b5c8e-cc15-4af4-ba60-40aa8301955e/resourceGroups/rg-7o8xwaka/providers/Microsoft.DBforPostgreSQL/flexibleServers/pg-fs-7o8xwaka/databases/pg-fs-db-7o8xwaka]
module.server.module.redis.azurerm_private_endpoint.this: Refreshing state... [id=/subscriptions/0f6b5c8e-cc15-4af4-ba60-40aa8301955e/resourceGroups/rg-7o8xwaka/providers/Microsoft.Network/privateEndpoints/endpoint-7o8xwaka]
module.server.azurerm_key_vault_secret.redis_connection_string: Refreshing state... [id=https://key-vault-7o8xwaka.vault.azure.net/secrets/redis-connection-string/299b4c157e03410794728208e582ae51]
module.server.azurerm_key_vault_secret.db_connection_string: Refreshing state... [id=https://key-vault-7o8xwaka.vault.azure.net/secrets/db-connection-string/722a31c6866e4ee5ba94f11514653007]
module.server.azurerm_key_vault_secret.session_secret: Refreshing state... [id=https://key-vault-7o8xwaka.vault.azure.net/secrets/session-secret/d25064f2b362478e82fbadf42021336c]
module.server.module.blob_storage.azurerm_storage_container.main: Refreshing state... [id=https://appstore7o8xwaka.blob.core.windows.net/appstore7o8xwakacontainer]
module.server.azurerm_role_assignment.blob_storage_contributor: Refreshing state... [id=/subscriptions/0f6b5c8e-cc15-4af4-ba60-40aa8301955e/resourceGroups/rg-7o8xwaka/providers/Microsoft.Storage/storageAccounts/appstore7o8xwaka/providers/Microsoft.Authorization/roleAssignments/e740280c-e9be-ebb4-b0dc-20f69797890f]
module.server.azurerm_container_app.worker: Refreshing state... [id=/subscriptions/0f6b5c8e-cc15-4af4-ba60-40aa8301955e/resourceGroups/rg-7o8xwaka/providers/Microsoft.App/containerApps/worker-7o8xwaka]
module.server.azurerm_container_app.server: Refreshing state... [id=/subscriptions/0f6b5c8e-cc15-4af4-ba60-40aa8301955e/resourceGroups/rg-7o8xwaka/providers/Microsoft.App/containerApps/server-7o8xwaka]

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # module.server.azurerm_container_app.server will be updated in-place
  ~ resource "azurerm_container_app" "server" {
        id                            = "/subscriptions/0f6b5c8e-cc15-4af4-ba60-40aa8301955e/resourceGroups/rg-7o8xwaka/providers/Microsoft.App/containerApps/server-7o8xwaka"
        name                          = "server-7o8xwaka"
        tags                          = {
            "environment" = "production"
            "workspace"   = "default"
        }
        # (8 unchanged attributes hidden)

      ~ template {
            # (2 unchanged attributes hidden)

          ~ container {
              ~ image             = "ghcr.io/rubberdok/server:d576a2a4445e8d37c7f3b48cbb9139840d6d2de5" -> "ghcr.io/rubberdok/server:latest"
                name              = "server"
                # (5 unchanged attributes hidden)

              ~ env {
                    name  = "SENTRY_RELEASE"
                  ~ value = "d576a2a4445e8d37c7f3b48cbb9139840d6d2de5" -> "61817a42d20611a520e3fc757547fa91dad1cb43"
                }

                # (29 unchanged blocks hidden)
            }

          ~ init_container {
              ~ image             = "ghcr.io/rubberdok/server:d576a2a4445e8d37c7f3b48cbb9139840d6d2de5" -> "ghcr.io/rubberdok/server:latest"
                name              = "migrate"
                # (5 unchanged attributes hidden)

              ~ env {
                    name  = "SENTRY_RELEASE"
                  ~ value = "d576a2a4445e8d37c7f3b48cbb9139840d6d2de5" -> "61817a42d20611a520e3fc757547fa91dad1cb43"
                }

                # (26 unchanged blocks hidden)
            }
        }

        # (9 unchanged blocks hidden)
    }

  # module.server.azurerm_container_app.worker will be updated in-place
  ~ resource "azurerm_container_app" "worker" {
        id                            = "/subscriptions/0f6b5c8e-cc15-4af4-ba60-40aa8301955e/resourceGroups/rg-7o8xwaka/providers/Microsoft.App/containerApps/worker-7o8xwaka"
        name                          = "worker-7o8xwaka"
        tags                          = {
            "environment" = "production"
            "workspace"   = "default"
        }
        # (7 unchanged attributes hidden)

      ~ template {
            # (2 unchanged attributes hidden)

          ~ container {
              ~ image             = "ghcr.io/rubberdok/server:d576a2a4445e8d37c7f3b48cbb9139840d6d2de5" -> "ghcr.io/rubberdok/server:latest"
                name              = "worker"
                # (5 unchanged attributes hidden)

              ~ env {
                    name  = "SENTRY_RELEASE"
                  ~ value = "d576a2a4445e8d37c7f3b48cbb9139840d6d2de5" -> "61817a42d20611a520e3fc757547fa91dad1cb43"
                }

                # (26 unchanged blocks hidden)
            }
        }

        # (8 unchanged blocks hidden)
    }

  # module.server.module.blob_storage.azurerm_storage_account.main will be updated in-place
  ~ resource "azurerm_storage_account" "main" {
        id                                = "/subscriptions/0f6b5c8e-cc15-4af4-ba60-40aa8301955e/resourceGroups/rg-7o8xwaka/providers/Microsoft.Storage/storageAccounts/appstore7o8xwaka"
        name                              = "appstore7o8xwaka"
        tags                              = {}
        # (37 unchanged attributes hidden)

      ~ blob_properties {
            # (4 unchanged attributes hidden)

          ~ cors_rule {
              ~ allowed_headers    = [
                  - "x-ms-blob-content-type",
                  - "x-ms-blob-type",
                  - "x-ms-client-request-id",
                  - "x-ms-version",
                  + "*",
                ]
              ~ allowed_methods    = [
                    # (6 unchanged elements hidden)
                    "OPTIONS",
                  + "PUT",
                    "PATCH",
                ]
                # (3 unchanged attributes hidden)
            }
        }

        # (4 unchanged blocks hidden)
    }

Plan: 0 to add, 3 to change, 0 to destroy.

─────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.

Pushed by: @larwaa, Action: pull_request

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 96.83258% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 93.34%. Comparing base (d576a2a) to head (fd871da).
Report is 1 commits behind head on main.

Files Patch % Lines
src/repositories/organizations/members.ts 93.93% 4 Missing ⚠️
src/services/organizations/members.ts 91.89% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #553      +/-   ##
==========================================
+ Coverage   93.32%   93.34%   +0.02%     
==========================================
  Files         222      223       +1     
  Lines       16699    16833     +134     
  Branches     1558     1597      +39     
==========================================
+ Hits        15584    15713     +129     
- Misses       1111     1116       +5     
  Partials        4        4              
Flag Coverage Δ
integrationtests 72.77% <71.94%> (+0.23%) ⬆️
node 93.34% <96.83%> (+0.02%) ⬆️
unittests 50.38% <50.67%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Mar 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@larwaa larwaa merged commit ab47070 into main Mar 15, 2024
18 checks passed
@larwaa larwaa deleted the feature/members/add-by-email branch March 15, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant