Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: mask internal server errors #350

Merged
merged 3 commits into from
Jan 9, 2024
Merged

Conversation

larwaa
Copy link
Member

@larwaa larwaa commented Jan 9, 2024

Changes

  • Mask all errors except user facing errors as Internal Server Error to avoid leaking implementation details.

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (32aef2b) 95.00% compared to head (c16c77c) 95.22%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #350      +/-   ##
==========================================
+ Coverage   95.00%   95.22%   +0.21%     
==========================================
  Files         127      127              
  Lines        6951     6952       +1     
  Branches      549      631      +82     
==========================================
+ Hits         6604     6620      +16     
+ Misses        334      319      -15     
  Partials       13       13              
Flag Coverage Δ
integrationtests 77.90% <100.00%> (+0.21%) ⬆️
node 95.22% <100.00%> (+0.21%) ⬆️
unittests 48.97% <52.00%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@larwaa larwaa changed the title chore: mask server errors chore: mask internal server errors Jan 9, 2024
Copy link

sonarcloud bot commented Jan 9, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@larwaa larwaa merged commit a14cbb0 into main Jan 9, 2024
17 checks passed
@larwaa larwaa deleted the chore/mask-internal-errors branch January 9, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant