✨ feat(cabins): get booking (#565)

* ✨ feat(cabins): get booking

* chore: rename to byIdAndEmail to avoid collision

schema.graphql

@@ -46,6 +46,7 @@ type Booking {
  """
  feedback: String!
  firstName: String!
+ guests: Guests!
  id: ID!
  lastName: String!
  phoneNumber: String!
@@ -71,6 +72,15 @@ type BookingContactResponse {
  bookingContact: BookingContact!
 }
 
+input BookingInput {
+ email: String!
+ id: ID!
+}
+
+type BookingResponse {
+ booking: Booking
+}
+
 type BookingSemester {
  bookingsEnabled: Boolean!
  endAt: DateTime!
@@ -632,6 +642,11 @@ type GetAvailabilityCalendarResponse {
  calendarMonths: [CalendarMonth!]!
 }
 
+type Guests {
+ external: Int!
+ internal: Int!
+}
+
 input GuestsInput {
  external: Int!
  internal: Int!
@@ -1127,6 +1142,7 @@ type PublicUser {
 }
 
 type Query {
+ booking(data: BookingInput!): BookingResponse!
  bookingContact: BookingContactResponse!
  bookingSemesters: BookingSemestersResponse!
  bookingTerms: BookingTermsResponse!

src/graphql/cabins/resolvers/Booking.ts

@@ -8,4 +8,10 @@ export const Booking: BookingResolvers = {
  );
  return cabinsResult;
  },
+ guests: ({ internalParticipantsCount, externalParticipantsCount }) => {
+ return {
+ external: externalParticipantsCount,
+ internal: internalParticipantsCount,
+ };
+ },
 };

src/graphql/cabins/resolvers/BookingResponse.ts

@@ -0,0 +1,4 @@
+import type { BookingResponseResolvers } from "./../../types.generated.js";
+export const BookingResponse: BookingResponseResolvers = {
+ /* Implement BookingResponse resolver logic here */
+};

src/graphql/cabins/resolvers/Guests.ts

@@ -0,0 +1,4 @@
+import type { GuestsResolvers } from "./../../types.generated.js";
+export const Guests: GuestsResolvers = {
+ /* Implement Guests resolver logic here */
+};

src/graphql/cabins/resolvers/Query/booking.ts

@@ -0,0 +1,19 @@
+import type { QueryResolvers } from "./../../../types.generated.js";
+export const booking: NonNullable<QueryResolvers["booking"]> = async (
+ _parent,
+ { data },
+ ctx,
+) => {
+ const getBookingResult = await ctx.cabins.getBookingByIdAndEmail(ctx, data);
+ if (!getBookingResult.ok) {
+ switch (getBookingResult.error.name) {
+ case "InternalServerError":
+ throw getBookingResult.error;
+ case "NotFoundError":
+ return {
+ booking: null,
+ };
+ }
+ }
+ return getBookingResult.data;
+};

src/graphql/cabins/resolvers/Query/booking.unit.test.ts

@@ -0,0 +1,136 @@
+import { faker } from "@faker-js/faker";
+import { Booking } from "~/domain/cabins.js";
+import { InternalServerError, NotFoundError } from "~/domain/errors.js";
+import { createMockApolloServer } from "~/graphql/test-clients/mock-apollo-server.js";
+import { graphql } from "~/graphql/test-clients/unit/gql.js";
+import { Result } from "~/lib/result.js";
+
+describe("Cabin queries", () => {
+ describe("booking", () => {
+ it("returns a booking", async () => {
+ const { client, cabinService } = createMockApolloServer();
+ const booking = new Booking({
+ cabins: [],
+ createdAt: faker.date.recent(),
+ email: faker.internet.email(),
+ endDate: faker.date.recent(),
+ externalParticipantsCount: faker.number.int({ max: 10 }),
+ feedback: faker.lorem.paragraph(),
+ firstName: faker.person.firstName(),
+ id: faker.string.uuid(),
+ internalParticipantsCount: faker.number.int({ max: 10 }),
+ lastName: faker.person.lastName(),
+ phoneNumber: faker.phone.number(),
+ questions: faker.lorem.paragraph(),
+ startDate: faker.date.recent(),
+ status: "PENDING",
+ totalCost: faker.number.int({ max: 200 }),
+ });
+ cabinService.getBookingByIdAndEmail.mockResolvedValue(
+ Result.success({
+ booking,
+ }),
+ );
+
+ const { data } = await client.query({
+ query: graphql(`
+ query Booking($data: BookingInput!) {
+ booking(data: $data) {
+ booking {
+ id
+ guests {
+ internal
+ external
+ }
+ }
+ }
+ }
+ `),
+ variables: {
+ data: {
+ id: faker.string.uuid(),
+ email: faker.internet.email(),
+ },
+ },
+ });
+
+ expect(data).toEqual({
+ booking: {
+ booking: {
+ id: booking.id,
+ guests: {
+ internal: booking.internalParticipantsCount,
+ external: booking.externalParticipantsCount,
+ },
+ },
+ },
+ });
+ });
+
+ it("returns null on NotFoundError", async () => {
+ const { client, cabinService } = createMockApolloServer();
+ cabinService.getBookingByIdAndEmail.mockResolvedValue(
+ Result.error(new NotFoundError("")),
+ );
+
+ const { data } = await client.query({
+ query: graphql(`
+ query Booking($data: BookingInput!) {
+ booking(data: $data) {
+ booking {
+ id
+ guests {
+ internal
+ external
+ }
+ }
+ }
+ }
+ `),
+ variables: {
+ data: {
+ id: faker.string.uuid(),
+ email: faker.internet.email(),
+ },
+ },
+ });
+
+ expect(data).toEqual({
+ booking: {
+ booking: null,
+ },
+ });
+ });
+
+ it("throws on InternalServerError", async () => {
+ const { client, cabinService } = createMockApolloServer();
+ cabinService.getBookingByIdAndEmail.mockResolvedValue(
+ Result.error(new InternalServerError("")),
+ );
+
+ const { errors } = await client.query({
+ query: graphql(`
+ query Booking($data: BookingInput!) {
+ booking(data: $data) {
+ booking {
+ id
+ guests {
+ internal
+ external
+ }
+ }
+ }
+ }
+ `),
+ variables: {
+ data: {
+ id: faker.string.uuid(),
+ email: faker.internet.email(),
+ },
+ },
+ });
+
+ expect(errors).toBeDefined();
+ });
+ });
+});

src/graphql/cabins/schema.graphql

@@ -1,4 +1,5 @@
 type Query {
+ booking(data: BookingInput!): BookingResponse!
  cabins: CabinsResponse!
  bookingSemesters: BookingSemestersResponse!
  bookingContact: BookingContactResponse!
@@ -43,6 +44,15 @@ type Mutation {
  updateBookingTerms: UpdateBookingTermsResponse!
 }
 
+input BookingInput {
+ id: ID!
+ email: String!
+}
+
+type BookingResponse {
+ booking: Booking
+}
+
 type BookingTermsResponse {
  bookingTerms: BookingTerms
 }
@@ -158,6 +168,12 @@ type Booking {
  Feedback from the cabin administrators to the user, e.g. why a booking was rejected
  """
  feedback: String!
+ guests: Guests!
+}
+
+type Guests {
+ internal: Int!
+ external: Int!
 }
 
 type BookingContact {

src/graphql/cabins/schema.mappers.ts

@@ -2,7 +2,7 @@
 type BookingSemestersResponseMapper = {};
 
 export type {
- BookingType as BookingMapper,
+ Booking as BookingMapper,
  BookingSemester as BookingSemesterMapper,
  Cabin as CabinMapper,
  CalendarMonth as CalendarMonthMapper,

src/lib/server.ts

@@ -7,6 +7,7 @@ import type { FastifyInstance, FastifyRequest } from "fastify";
 import { BlobStorageAdapter } from "~/adapters/azure-blob-storage.js";
 import { type Configuration, env } from "~/config.js";
 import type {
+ Booking,
  BookingContact,
  BookingSemester,
  BookingSemesterEnumType,
@@ -388,6 +389,10 @@ interface ICabinService {
  { bookingTerms: BookingTerms },
  NotFoundError | InternalServerError
  >;
+ getBookingByIdAndEmail(
+ ctx: Context,
+ params: { id: string; email: string },
+ ): ResultAsync<{ booking: Booking }, NotFoundError | InternalServerError>;
 }
 
 interface IEventService {

src/services/cabins/__tests__/unit/get-booking-by-id-and-email.test.ts

@@ -0,0 +1,100 @@
+import { faker } from "@faker-js/faker";
+import { Booking } from "~/domain/cabins.js";
+import { NotFoundError } from "~/domain/errors.js";
+import { makeMockContext } from "~/lib/context.js";
+import { Result } from "~/lib/result.js";
+import { makeDependencies } from "./dependencies.js";
+
+describe("Cabin service", () => {
+ describe("#getBookingByIdAndEmail", () => {
+ it("returns a booking if the email matches the booking", async () => {
+ const { cabinService, cabinRepository } = makeDependencies();
+ const email = faker.internet.email();
+
+ const booking = new Booking({
+ id: faker.string.uuid(),
+ cabins: [],
+ createdAt: faker.date.recent(),
+ email,
+ endDate: faker.date.recent(),
+ externalParticipantsCount: faker.number.int({ max: 10 }),
+ feedback: faker.lorem.paragraph(),
+ firstName: faker.person.firstName(),
+ internalParticipantsCount: faker.number.int({ max: 10 }),
+ lastName: faker.person.lastName(),
+ phoneNumber: faker.phone.number(),
+ questions: faker.lorem.paragraph(),
+ startDate: faker.date.recent(),
+ status: "PENDING",
+ totalCost: faker.number.int({ max: 200 }),
+ });
+
+ cabinRepository.getBookingById.mockResolvedValue(
+ Result.success({ booking }),
+ );
+
+ const result = await cabinService.getBookingByIdAndEmail(
+ makeMockContext(),
+ {
+ id: faker.string.uuid(),
+ email,
+ },
+ );
+
+ expect(result).toEqual(Result.success({ booking }));
+ });
+
+ it("returns NotFound if the email does not match the booking", async () => {
+ const { cabinService, cabinRepository } = makeDependencies();
+
+ const booking = new Booking({
+ id: faker.string.uuid(),
+ cabins: [],
+ createdAt: faker.date.recent(),
+ email: faker.internet.email({ firstName: "test" }),
+ endDate: faker.date.recent(),
+ externalParticipantsCount: faker.number.int({ max: 10 }),
+ feedback: faker.lorem.paragraph(),
+ firstName: faker.person.firstName(),
+ internalParticipantsCount: faker.number.int({ max: 10 }),
+ lastName: faker.person.lastName(),
+ phoneNumber: faker.phone.number(),
+ questions: faker.lorem.paragraph(),
+ startDate: faker.date.recent(),
+ status: "PENDING",
+ totalCost: faker.number.int({ max: 200 }),
+ });
+
+ cabinRepository.getBookingById.mockResolvedValue(
+ Result.success({ booking }),
+ );
+
+ const result = await cabinService.getBookingByIdAndEmail(
+ makeMockContext(),
+ {
+ id: faker.string.uuid(),
+ email: faker.internet.email({ firstName: "not-test" }),
+ },
+ );
+
+ expect(result).toEqual(Result.error(expect.any(NotFoundError)));
+ });
+ it("returns NotFound if the repository returns NotFound", async () => {
+ const { cabinService, cabinRepository } = makeDependencies();
+
+ cabinRepository.getBookingById.mockResolvedValue(
+ Result.error(new NotFoundError("")),
+ );
+
+ const result = await cabinService.getBookingByIdAndEmail(
+ makeMockContext(),
+ {
+ id: faker.string.uuid(),
+ email: faker.internet.email(),
+ },
+ );
+
+ expect(result).toEqual(Result.error(expect.any(NotFoundError)));
+ });
+ });
+});