Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix group permissions convert #321

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Fix group permissions convert #321

merged 1 commit into from
Apr 8, 2024

Conversation

wanglam
Copy link
Collaborator

@wanglam wanglam commented Apr 8, 2024

Description

Fix permissions group converting, add related unit tests.

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@wanglam wanglam marked this pull request as ready for review April 8, 2024 07:53
@wanglam wanglam requested a review from SuZhou-Joe as a code owner April 8, 2024 07:53
Hailong-am
Hailong-am approved these changes Apr 8, 2024
View reviewed changes
Copy link
Collaborator

@Hailong-am Hailong-am left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quick fix

@wanglam wanglam merged commit e2a8ae2 into ruanyl:workspace-pr-integr Apr 8, 2024
41 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hailong-am Hailong-am Hailong-am approved these changes

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

Assignees
No one assigned
Labels
all-star-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wanglam @Hailong-am