Add a workspace dropdown menu in left navigation bar #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit, the workspace plugin registered a workspace dropdown menu on the top of left navigation bar. This allows user to quickly switch the current workspace. Signed-off-by: Yulong Ruan <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## workspace-pr-integr #282 +/- ##
=======================================================
+ Coverage 66.94% 67.23% +0.28%
=======================================================
Files 3322 3327 +5
Lines 64139 65451 +1312
Branches 10289 10735 +446
=======================================================
+ Hits 42938 44005 +1067
- Misses 18687 18872 +185
- Partials 2514 2574 +60
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SuZhou-Joe
reviewed
Mar 6, 2024
src/plugins/workspace/public/components/workspace_menu/workspace_menu.tsx
Outdated
Show resolved
Hide resolved
SuZhou-Joe
reviewed
Mar 6, 2024
src/plugins/workspace/public/components/workspace_menu/workspace_menu.tsx
Outdated
Show resolved
Hide resolved
SuZhou-Joe
reviewed
Mar 6, 2024
src/plugins/workspace/public/components/workspace_menu/workspace_menu.tsx
Outdated
Show resolved
Hide resolved
SuZhou-Joe
approved these changes
Mar 6, 2024
src/plugins/workspace/public/components/workspace_menu/workspace_menu.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Yulong Ruan <[email protected]>
Signed-off-by: Yulong Ruan <[email protected]>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Mar 18, 2024
In this commit, the workspace plugin registered a workspace dropdown menu on the top of left navigation bar. This allows user to quickly switch the current workspace and navigate to workspace create page and workspace list page from the dropdown sticky on the top of the left nav bar. Signed-off-by: Yulong Ruan <[email protected]> --------- Signed-off-by: Yulong Ruan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, the workspace plugin registered a workspace dropdown menu on the top of left navigation bar. This allows user to quickly switch the current workspace.
Description
Issues Resolved
Screenshot
Testing the changes
Check List
yarn test:jestyarn test:jest_integration