Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: backport pr 5949 to workspace-pr-inte #275

Conversation

SuZhou-Joe
Copy link
Collaborator

@SuZhou-Joe SuZhou-Joe commented Mar 4, 2024

Description

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: SuZhou-Joe <[email protected]>
@SuZhou-Joe SuZhou-Joe changed the title feat: merge 5949 feat: backport pr 5949 to workspace-pr-inte Mar 4, 2024
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 72.22222% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 66.93%. Comparing base (57ee06d) to head (fd19eb1).

Files Patch % Lines
...ved_objects/service/lib/search_dsl/query_params.ts 50.00% 1 Missing and 1 partial ⚠️
...rc/core/server/saved_objects/routes/bulk_create.ts 0.00% 1 Missing ⚠️
src/core/server/saved_objects/routes/find.ts 0.00% 1 Missing ⚠️
...ore/server/saved_objects/service/lib/repository.ts 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                   Coverage Diff                   @@
##           workspace-pr-integr     #275      +/-   ##
=======================================================
- Coverage                66.94%   66.93%   -0.02%     
=======================================================
  Files                     3322     2601     -721     
  Lines                    64139    49096   -15043     
  Branches                 10289     8868    -1421     
=======================================================
- Hits                     42938    32860   -10078     
+ Misses                   18687    14060    -4627     
+ Partials                  2514     2176     -338     
Flag Coverage Δ
Linux_ ?
_1 ?
_2 55.32% <72.22%> (-0.02%) ⬇️
_3 43.42% <0.00%> (+0.01%) ⬆️
_4 35.19% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: SuZhou-Joe <[email protected]>
@SuZhou-Joe SuZhou-Joe merged commit c5050d3 into ruanyl:workspace-pr-integr Mar 4, 2024
42 of 45 checks passed
SuZhou-Joe added a commit that referenced this pull request Mar 18, 2024
* feat: merge 5949

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update snapshot

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: bootstrap error

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: unit test error

Signed-off-by: SuZhou-Joe <[email protected]>

---------

Signed-off-by: SuZhou-Joe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants