Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE]Feature/workspace parameters ci #270

Closed

Conversation

SuZhou-Joe
Copy link
Collaborator

Description

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@SuZhou-Joe SuZhou-Joe changed the title [DO not merge]Feature/workspace parameters ci [DO NOT MERGE]Feature/workspace parameters ci Mar 2, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2024

Codecov Report

Attention: Patch coverage is 80.35714% with 44 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main-ci@0c394bd). Click here to learn what that means.

Files Patch % Lines
...ed_objects_wrapper_for_check_workspace_conflict.ts 86.58% 3 Missing and 8 partials ⚠️
.../plugins/application_config/server/routes/index.ts 76.47% 8 Missing ⚠️
src/plugins/application_config/server/plugin.ts 78.94% 3 Missing and 1 partial ⚠️
src/core/server/saved_objects/routes/import.ts 0.00% 3 Missing ⚠️
...rver/saved_objects/routes/resolve_import_errors.ts 0.00% 3 Missing ⚠️
...rc/core/server/saved_objects/routes/bulk_create.ts 0.00% 2 Missing ⚠️
src/core/server/saved_objects/routes/create.ts 0.00% 2 Missing ⚠️
...ore/server/saved_objects/service/lib/repository.ts 71.42% 0 Missing and 2 partials ⚠️
...ved_objects/service/lib/search_dsl/query_params.ts 66.66% 1 Missing and 1 partial ⚠️
.../plugins/application_config/server/string_utils.ts 77.77% 1 Missing and 1 partial ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main-ci     #270   +/-   ##
==========================================
  Coverage           ?   67.04%           
==========================================
  Files              ?     3315           
  Lines              ?    63904           
  Branches           ?    10220           
==========================================
  Hits               ?    42845           
  Misses             ?    18569           
  Partials           ?     2490           
Flag Coverage Δ
Linux_1 31.64% <59.16%> (?)
Linux_2 55.07% <52.63%> (?)
Linux_3 44.59% <62.67%> (?)
Linux_4 35.17% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…t#5855)

* Add application configuration service

Signed-off-by: Tianle Huang <[email protected]>

* update API path name

Signed-off-by: Tianle Huang <[email protected]>

* implement two APIs/interfaces

Signed-off-by: Tianle Huang <[email protected]>

* expose get function for other plugins to use

Signed-off-by: Tianle Huang <[email protected]>

* update interfaces

Signed-off-by: Tianle Huang <[email protected]>

* implement the APIs and interfaces

Signed-off-by: Tianle Huang <[email protected]>

* add license and jsdoc

Signed-off-by: Tianle Huang <[email protected]>

* update docs

Signed-off-by: Tianle Huang <[email protected]>

* add more docs

Signed-off-by: Tianle Huang <[email protected]>

* update variable name

Signed-off-by: Tianle Huang <[email protected]>

* remove unnecessary dependency

Signed-off-by: Tianle Huang <[email protected]>

* format readme

Signed-off-by: Tianle Huang <[email protected]>

* use osd version

Signed-off-by: Tianle Huang <[email protected]>

* remove debugging info

Signed-off-by: Tianle Huang <[email protected]>

* update logging

Signed-off-by: Tianle Huang <[email protected]>

* remove lint js

Signed-off-by: Tianle Huang <[email protected]>

* remove logs

Signed-off-by: Tianle Huang <[email protected]>

* update name style

Signed-off-by: Tianle Huang <[email protected]>

* update

Signed-off-by: Tianle Huang <[email protected]>

* update function visibility and error function

Signed-off-by: Tianle Huang <[email protected]>

* fix unit test failures

Signed-off-by: Tianle Huang <[email protected]>

* add unit test

Signed-off-by: Tianle Huang <[email protected]>

* remove lint file

Signed-off-by: Tianle Huang <[email protected]>

* add more tests

Signed-off-by: Tianle Huang <[email protected]>

* add unit tests for routes

Signed-off-by: Tianle Huang <[email protected]>

* add remaining unit tests

Signed-off-by: Tianle Huang <[email protected]>

* add enabled to this plugin

Signed-off-by: Tianle Huang <[email protected]>

* update readme to mention experimental

Signed-off-by: Tianle Huang <[email protected]>

* update change log

Signed-off-by: Tianle Huang <[email protected]>

* dummy commit to trigger workflow rerun

Signed-off-by: Tianle Huang <[email protected]>

* remove experimental

Signed-off-by: Tianle Huang <[email protected]>

* add key to yml file

Signed-off-by: Tianle Huang <[email protected]>

* remove i18n

Signed-off-by: Tianle Huang <[email protected]>

* remove lint rc

Signed-off-by: Tianle Huang <[email protected]>

* update comment style

Signed-off-by: Tianle Huang <[email protected]>

* add input validation

Signed-off-by: Tianle Huang <[email protected]>

* update unit tests

Signed-off-by: Tianle Huang <[email protected]>

* prevent multiple registration

Signed-off-by: Tianle Huang <[email protected]>

* add return types

Signed-off-by: Tianle Huang <[email protected]>

* update readme wording

Signed-off-by: Tianle Huang <[email protected]>

* add unit test to the plugin class about double register

Signed-off-by: Tianle Huang <[email protected]>

* move related ymls

Signed-off-by: Tianle Huang <[email protected]>

* move validation to a function

Signed-off-by: Tianle Huang <[email protected]>

* use trimmed versions

Signed-off-by: Tianle Huang <[email protected]>

* reword changelog entry

Signed-off-by: Tianle Huang <[email protected]>

* readability

Signed-off-by: Tianle Huang <[email protected]>

* add back yml change

Signed-off-by: Tianle Huang <[email protected]>

---------

Signed-off-by: Tianle Huang <[email protected]>
@SuZhou-Joe SuZhou-Joe force-pushed the feature/workspace-parameters-ci branch from 9a1a690 to 21bcde8 Compare March 2, 2024 14:08
SuZhou-Joe and others added 25 commits March 2, 2024 22:09
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: gaobinlong <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
@SuZhou-Joe SuZhou-Joe force-pushed the feature/workspace-parameters-ci branch from 21bcde8 to 5c13c48 Compare March 2, 2024 14:11
SuZhou-Joe and others added 7 commits March 3, 2024 22:06
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
* feat: add self host runner

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update

* feat: update

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: use v4

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update

Signed-off-by: SuZhou-Joe <[email protected]>

* Revert "feat: use v4"

This reverts commit fc24867.

* feat: use auto-scaleable runners

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: use sudo

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update

Signed-off-by: SuZhou-Joe <[email protected]>

---------

Signed-off-by: SuZhou-Joe <[email protected]>
…ch-project#161)

the jobs for windows are queued forever, disable it for development

Signed-off-by: Yulong Ruan <[email protected]>

temp: skip bwc-tests

Signed-off-by: SuZhou-Joe <[email protected]>

---------

Signed-off-by: Yulong Ruan <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Co-authored-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
@SuZhou-Joe SuZhou-Joe force-pushed the feature/workspace-parameters-ci branch from 5c13c48 to 7677b67 Compare March 3, 2024 14:31
SuZhou-Joe and others added 5 commits March 4, 2024 10:14
…ct#5949)

* refact: move workspace specific logic to savedObjectWrapper

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: some error

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: fix test error

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: remove useless config in test

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add CHANGELOG

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add more unit test

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: unit test

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: revert test in repository.test.js

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: revert test in import_saved_objects.test.ts

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: revert test in repository.test.js

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add type

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: bootstrap type error

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: optimize code and add comment

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: unit test error

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: integration test fail

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add missing code

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: optimize code

Signed-off-by: SuZhou-Joe <[email protected]>

* Add permissions field to the mapping only if the permission control is enabled

Signed-off-by: gaobinlong <[email protected]>

* Fix test failure

Signed-off-by: gaobinlong <[email protected]>

* feat: modify unit test

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: bulk create error

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: bulk create error

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add new config in yml file

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add new config in yml file

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update yml file

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: fix unit test

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: do not skip migration when doing integration test

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: remove useless code

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: remove useless code

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: change flag variable

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add test cases

Signed-off-by: SuZhou-Joe <[email protected]>

---------

Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: gaobinlong <[email protected]>
Co-authored-by: gaobinlong <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
@SuZhou-Joe SuZhou-Joe closed this Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants