Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport workspace-pr-integr] Refactor: move workspace logic from repository to saved objects client wrapper #264

Conversation

SuZhou-Joe
Copy link
Collaborator

manual backport #248

@codecov-commenter
Copy link

codecov-commenter commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 79.54545% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 55.68%. Comparing base (57ee06d) to head (6316a9a).

Files Patch % Lines
...ed_objects_wrapper_for_check_workspace_conflict.ts 87.01% 2 Missing and 8 partials ⚠️
...ore/server/saved_objects/service/lib/repository.ts 0.00% 6 Missing ⚠️
...server/saved_objects/import/validate_references.ts 0.00% 1 Missing ⚠️
src/plugins/workspace/server/plugin.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                    @@
##           workspace-pr-integr     #264       +/-   ##
========================================================
- Coverage                66.94%   55.68%   -11.27%     
========================================================
  Files                     3322     3034      -288     
  Lines                    64139    60104     -4035     
  Branches                 10289     9656      -633     
========================================================
- Hits                     42938    33466     -9472     
- Misses                   18687    24627     +5940     
+ Partials                  2514     2011      -503     
Flag Coverage Δ
_1 31.98% <79.54%> (+0.28%) ⬆️
_2 ?
_3 43.45% <0.00%> (+0.05%) ⬆️
_4 35.21% <0.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…t wrapper (opensearch-project#248)

* refact: move workspace specific logic to savedObjectWrapper

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: remove unnecessary changes

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: unit test

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: some error

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: some error

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: unit test error

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: fix test error

Signed-off-by: SuZhou-Joe <[email protected]>

* refact: move workspace specific logic to savedObjectWrapper

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: some error

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: fix test error

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: remove useless config in test

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add CHANGELOG

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add more unit test

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: unit test

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: revert test in repository.test.js

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: revert test in import_saved_objects.test.ts

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: revert test in repository.test.js

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add type

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: optimize code and add comment

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: unit test error

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: integration test fail

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add missing code

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: fix bootstrap error

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: remove useless code

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: remove useless code

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: remove useless code

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: optimize code

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: unit test

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: remove useless code

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: optimize code

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: remove useless CHANGELOG

Signed-off-by: SuZhou-Joe <[email protected]>

---------

Signed-off-by: SuZhou-Joe <[email protected]>
(cherry picked from commit 415605f)
Signed-off-by: SuZhou-Joe <[email protected]>
@SuZhou-Joe SuZhou-Joe force-pushed the backport/backport-248-to-workspace-pr-integr branch from 758a358 to 6316a9a Compare March 1, 2024 02:36
@SuZhou-Joe SuZhou-Joe closed this Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants