update workspace list #259
Conversation
Signed-off-by: tygao <[email protected]>
Signed-off-by: tygao <[email protected]>
Signed-off-by: tygao <[email protected]>
Signed-off-by: tygao <[email protected]>
Signed-off-by: tygao <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## workspace #259 +/- ##
==============================================
+ Coverage 55.60% 66.73% +11.12%
==============================================
Files 2260 3341 +1081
Lines 42470 64888 +22418
Branches 7539 10473 +2934
==============================================
+ Hits 23616 43300 +19684
- Misses 17394 18997 +1603
- Partials 1460 2591 +1131
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| onClose: () => void; | ||
| onConfirm: () => void; | ||
| selectedWorkspace?: WorkspaceAttribute | null; | ||
| ifNavigate: boolean; |
There was a problem hiding this comment.
what does ifNavigate used for? Only workspace list page have delete functionality, maybe we can remove this property as don't need to do direct after deleting.
There was a problem hiding this comment.
Workspace creator page will also use delete workspace model. And it will navigate after deleting in workspace creator page.
There was a problem hiding this comment.
How about renaming to shouldNavigate? ifNavigate seems not a good naming.
There was a problem hiding this comment.
maybe returnToHome to make it clear where will it redirect to?
| onClose: () => void; | ||
| onConfirm: () => void; | ||
| selectedWorkspace?: WorkspaceAttribute | null; | ||
| ifNavigate: boolean; |
There was a problem hiding this comment.
How about renaming to shouldNavigate? ifNavigate seems not a good naming.
src/plugins/workspace/public/components/workspace_list/index.tsx
Outdated
Show resolved
Hide resolved
src/plugins/workspace/public/components/workspace_list/workspace_actions_menu.tsx
Outdated
Show resolved
Hide resolved
| search={search} | ||
| /> | ||
| </EuiPageContent> | ||
| </EuiPageBody> | ||
| {delectedWorkspace && ( |
| return ( | ||
| <EuiPage paddingSize="none"> | ||
| <EuiPageBody panelled> | ||
| <EuiPageHeader | ||
| restrictWidth | ||
| pageTitle="Workspaces" | ||
| description={WORKSPACE_LIST_PAGE_DESCRIPTIOIN} | ||
| style={{ paddingBottom: 0, borderBottom: 0 }} |
There was a problem hiding this comment.
Can we control the style with paddingSize and bottomBorder props of EuiPageHeader?
There was a problem hiding this comment.
I tried to use bottomBorder before but it doesn't work.
Signed-off-by: tygao <[email protected]>
Signed-off-by: tygao <[email protected]>
Signed-off-by: tygao <[email protected]>
Description
update workspace list
Issues Resolved
Screenshot
Testing the changes
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr