Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch import sample data to workspace branch #227

Conversation

wanglam
Copy link
Collaborator

@wanglam wanglam commented Oct 13, 2023

Description

Patch #210 changes to workspace branch

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2023

Codecov Report

Merging #227 (f4b75ab) into workspace (a74a6ee) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##           workspace     #227      +/-   ##
=============================================
- Coverage      66.22%   66.21%   -0.01%     
=============================================
  Files           3422     3422              
  Lines          65748    65748              
  Branches       10587    10587              
=============================================
- Hits           43540    43538       -2     
+ Misses         19571    19566       -5     
- Partials        2637     2644       +7     
Flag Coverage Δ
Linux_1 30.42% <ø> (ø)
Linux_2 55.35% <ø> (ø)
Linux_3 42.78% <ø> (-0.01%) ⬇️
Linux_4 34.53% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...home/server/services/sample_data/data_sets/util.ts 80.85% <100.00%> (ø)

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wanglam wanglam changed the title refactor: assigned copied saved objects to new variables Path import sample data to workspace branch Oct 13, 2023
@wanglam wanglam marked this pull request as ready for review October 13, 2023 03:09
@wanglam wanglam changed the title Path import sample data to workspace branch Patch import sample data to workspace branch Oct 13, 2023
@wanglam wanglam merged commit dd486e9 into ruanyl:workspace Oct 13, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants