Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch: Move formatUrlWithWorkspaceId to core/utils #221

Closed
wants to merge 25 commits into from
Closed

Patch: Move formatUrlWithWorkspaceId to core/utils #221

wants to merge 25 commits into from

Conversation

SuZhou-Joe
Copy link
Collaborator

@SuZhou-Joe SuZhou-Joe commented Oct 11, 2023 •
edited
Loading

Description

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

SuZhou-Joe and others added 10 commits October 11, 2023 14:53
@SuZhou-Joe
feat: enable workspace id in basePath
43acbfb 
Signed-off-by: SuZhou-Joe <[email protected]>
@SuZhou-Joe
feat: add unit test
3c128d1 
Signed-off-by: SuZhou-Joe <[email protected]>
@raintygao @Hailong-am @SuZhou-Joe
Register Advance Settings, Data Source management,Index Pattern manag…
c5a1a64 
…ement and SavedObject management as standalone app, retire dashboard management (opensearch-project#208)

* feat: init retire dashboard management

Signed-off-by: tygao <[email protected]>

* move index pattern to Library (opensearch-project#91)

* move index pattern to libaray

Signed-off-by: Hailong Cui <[email protected]>

* Remove it from Dashboards management when workspace is on

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>

index pattern always show under library

Signed-off-by: Hailong Cui <[email protected]>

* functional test

Signed-off-by: Hailong Cui <[email protected]>

* feat: move data source / advanced settings / saved objects management out of Dashboard management

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update test

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update snapshot

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update snapshot

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: fix failed overview header ut

Signed-off-by: tygao <[email protected]>

* fix: deeplink inside saved objects management page

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: unit test fail

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add unit test for each page wrapper

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: some optimization

Signed-off-by: SuZhou-Joe <[email protected]>

* remove management dependency

Signed-off-by: Hailong Cui <[email protected]>

* test: update cypress config to use workspace branch

Signed-off-by: tygao <[email protected]>

* Replace ManagementAppMountParams with AppMountParameters

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: tygao <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Co-authored-by: Hailong Cui <[email protected]>
Co-authored-by: SuZhou-Joe <[email protected]>
@SuZhou-Joe
feat: remove useless test object id
8e1310b 
Signed-off-by: SuZhou-Joe <[email protected]>
@SuZhou-Joe
feat: add unit test
1e82266 
Signed-off-by: SuZhou-Joe <[email protected]>
@SuZhou-Joe
feat: add unit test
b3d9a00 
Signed-off-by: SuZhou-Joe <[email protected]>
@SuZhou-Joe
feat: update snapshot
a758fa8 
Signed-off-by: SuZhou-Joe <[email protected]>
@ruanyl @AMoo-Miki @SuZhou-Joe
remove unnecessary workspace enabled flag from core workspace module (o…
2ca6444 
…pensearch-project#215)

Update test description per comment

Signed-off-by: Yulong Ruan <[email protected]>
Co-authored-by: Miki <[email protected]>
@SuZhou-Joe
feat: move formatUrlWithWorkspaceId to core/public/utils
2cb7047 
Signed-off-by: SuZhou-Joe <[email protected]>
@SuZhou-Joe
feat: remove useless variable
2499584 
Signed-off-by: SuZhou-Joe <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2023 •
edited
Loading

Codecov Report

Merging #221 (cfbe94d) into workspace (2771ff9) will decrease coverage by 10.81%.
The diff coverage is 84.61%.

@@              Coverage Diff               @@
##           workspace     #221       +/-   ##
==============================================
- Coverage      66.20%   55.40%   -10.81%     
==============================================
  Files           3419     1190     -2229     
  Lines          65753    24059    -41694     
  Branches       10590     4032     -6558     
==============================================
- Hits           43535    13329    -30206     
+ Misses         19574    10075     -9499     
+ Partials        2644      655     -1989
Flag Coverage Δ
Linux_1 ?
Linux_2 55.40% <84.61%> (+0.03%) ⬆️
Linux_3 ?
Linux_4 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...lication/capabilities/capabilities_service.mock.ts 100.00% <ø> (ø)
src/core/public/http/http_service.mock.ts 100.00% <100.00%> (ø)
...c/core/public/workspace/workspaces_service.mock.ts 100.00% <ø> (ø)
src/core/public/workspace/workspaces_service.ts 88.88% <ø> (-1.12%) ⬇️
...e/server/capabilities/capabilities_service.mock.ts 75.00% <ø> (ø)
...c/core/server/capabilities/capabilities_service.ts 100.00% <ø> (ø)
src/core/public/utils/workspace.ts 87.50% <77.77%> (+16.07%) ⬆️

... and 2590 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@SuZhou-Joe
feat: remove useless code
cfbe94d 
Signed-off-by: SuZhou-Joe <[email protected]>
@SuZhou-Joe SuZhou-Joe changed the title Move formatUrlWithWorkspaceId to core/utils Patch: Move formatUrlWithWorkspaceId to core/utils Oct 11, 2023
@SuZhou-Joe SuZhou-Joe marked this pull request as draft October 11, 2023 09:29
@ruanyl ruanyl closed this Oct 11, 2023
@ruanyl ruanyl reopened this Oct 11, 2023
@SuZhou-Joe
Merge branch 'workspace' into feature/move-utils
20a64a5
@SuZhou-Joe
[Workspace]Add workspace id in basePath (opensearch-project#212)
4db94fc 
* feat: enable workspace id in basePath

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add unit test

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: remove useless test object id

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add unit test

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add unit test

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update snapshot

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: move formatUrlWithWorkspaceId to core/public/utils

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: remove useless variable

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: remove useless variable

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: optimization

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: optimization

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: optimization

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: move workspace/utils to core

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: move workspace/utils to core

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update comment

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: optimize code

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update unit test

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: optimization

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add space under license

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: unit test

Signed-off-by: SuZhou-Joe <[email protected]>

---------

Signed-off-by: SuZhou-Joe <[email protected]>
(cherry picked from commit 43e91fa)
@SuZhou-Joe
feat: optimization
2653ab4 
Signed-off-by: SuZhou-Joe <[email protected]>
@SuZhou-Joe
feat: optimization
1eb48dd 
Signed-off-by: SuZhou-Joe <[email protected]>
@SuZhou-Joe
feat: move workspace/utils to core
a1d00ea 
Signed-off-by: SuZhou-Joe <[email protected]>
@SuZhou-Joe
feat: update comment
2da5246 
Signed-off-by: SuZhou-Joe <[email protected]>
@SuZhou-Joe
feat: optimize code
2b6764a 
Signed-off-by: SuZhou-Joe <[email protected]>
@SuZhou-Joe
feat: update unit test
bf64805 
Signed-off-by: SuZhou-Joe <[email protected]>
@SuZhou-Joe
feat: optimization
6ea3891 
Signed-off-by: SuZhou-Joe <[email protected]>
@SuZhou-Joe
feat: add space under license
d0ac2ec 
Signed-off-by: SuZhou-Joe <[email protected]>
@SuZhou-Joe
fix: unit test
640c456 
Signed-off-by: SuZhou-Joe <[email protected]>
@SuZhou-Joe
Merge branch 'backport/backport-212-to-workspace' into feature/move-u…
a69e05e 
…tils
@SuZhou-Joe
feat: some sync
adc6029 
Signed-off-by: SuZhou-Joe <[email protected]>
@SuZhou-Joe SuZhou-Joe closed this Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
all-star-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SuZhou-Joe @codecov-commenter @ruanyl @raintygao