-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[API] Delete saved objects by workspace #216
[API] Delete saved objects by workspace #216
Conversation
0d7af3c
to
a3ed746
Compare
Codecov Report
@@ Coverage Diff @@
## workspace-pr-integr #216 +/- ##
====================================================
Coverage 66.48% 66.48%
====================================================
Files 3412 3412
Lines 65231 65240 +9
Branches 10456 10459 +3
====================================================
+ Hits 43367 43377 +10
Misses 19259 19259
+ Partials 2605 2604 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
body: { | ||
script: { | ||
source: ` | ||
if (!ctx._source.containsKey('workspaces')) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: will the results contain object without workspaces
field?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Base on current implementation, it won't.
Signed-off-by: Hailong Cui <[email protected]> fix osd boostrap Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
be0fdef
to
82c812b
Compare
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-workspace workspace
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-workspace
# Create a new branch
git switch --create backport/backport-216-to-workspace
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 77738118758626f30aa8ae5517e25e739a884cbd
# Push it to GitHub
git push --set-upstream origin backport/backport-216-to-workspace
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-workspace Then, create a pull request where the |
* Delete saved objects by workspace Signed-off-by: Hailong Cui <[email protected]> fix osd boostrap Signed-off-by: Hailong Cui <[email protected]> * add unit test Signed-off-by: Hailong Cui <[email protected]> * fix can't delete workspace due to invalid permission Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]>
* [API] Delete saved objects by workspace (#216) * Delete saved objects by workspace Signed-off-by: Hailong Cui <[email protected]> fix osd boostrap Signed-off-by: Hailong Cui <[email protected]> * add unit test Signed-off-by: Hailong Cui <[email protected]> * fix can't delete workspace due to invalid permission Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]> * update test case Signed-off-by: Hailong Cui <[email protected]> * Add change log Signed-off-by: Hailong Cui <[email protected]> * update change log format Signed-off-by: Hailong Cui <[email protected]> * update method comments to make it more clear Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]>
* Delete saved objects by workspace Signed-off-by: Hailong Cui <[email protected]> fix osd boostrap Signed-off-by: Hailong Cui <[email protected]> * add unit test Signed-off-by: Hailong Cui <[email protected]> * fix can't delete workspace due to invalid permission Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]>
…rch-project#6424) * [Workspace] Delete saved objects by workspace (opensearch-project#6013) * [API] Delete saved objects by workspace (#216) * Delete saved objects by workspace Signed-off-by: Hailong Cui <[email protected]> fix osd boostrap Signed-off-by: Hailong Cui <[email protected]> * add unit test Signed-off-by: Hailong Cui <[email protected]> * fix can't delete workspace due to invalid permission Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]> * update test case Signed-off-by: Hailong Cui <[email protected]> * Add change log Signed-off-by: Hailong Cui <[email protected]> * update change log format Signed-off-by: Hailong Cui <[email protected]> * update method comments to make it more clear Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]> (cherry picked from commit 735424b) * Update CHANGELOG.md Co-authored-by: SuZhou-Joe <[email protected]> Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]> Co-authored-by: SuZhou-Joe <[email protected]>
Description
Issues Resolved
Screenshot
Testing the changes
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr