Store current workspaceId into hash #209
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue Resolve opensearch-project#5068 Signed-off-by: ananzh <[email protected]>
…search-project#4882) * Add reactflow with compiler fix Signed-off-by: Tyler Ohlsen <[email protected]> * Update CHANGELOG Signed-off-by: Tyler Ohlsen <[email protected]> * Update comment Signed-off-by: Tyler Ohlsen <[email protected]> * Revert adding reactflow dep Signed-off-by: Tyler Ohlsen <[email protected]> --------- Signed-off-by: Tyler Ohlsen <[email protected]> Co-authored-by: Miki <[email protected]>
* Update yarn install step from dev guide Signed-off-by: Matt Provost <[email protected]> * Update the corepack command Signed-off-by: Matt Provost <[email protected]> * Update to use corepack install Signed-off-by: Matt Provost <[email protected]> * Revise corepack url Signed-off-by: Matt Provost <[email protected]> --------- Signed-off-by: Matt Provost <[email protected]>
* Add Bandini as maintainer Signed-off-by: Yan Zeng <[email protected]>
…roject#5134) Utilizing the GitHub `workflow_dispatch`, we can trigger a job with a specific inputs. By default, we run from this repo: https://github.com/opensearch-project/opensearch-dashboards-functional-test This workflow uses the target branch of the PR to pull down from the FTRepo and run the tests from that specific branch. For example, PRs against `main` will pull down `main` from the FTRepo. The problem occurs when new functionality is opened or a bug is fixed and, per industry standard, we want to see tests added to ensure functionality, stability, and raise the bar. However, the cypress tests PR into the FTRepo depends on the new code to be merged for the CI within the FTRepo to work. So we have a stalemate that usually slows down PR review time. Here, a manual run can be triggered by a maintainer. It will utilize the source branch from the PR if provided. Related to: opensearch-project#4019 Signed-off-by: Kawika Avilla <[email protected]>
Originally: opensearch-project#5134 I believed it to be a good idea to ensure that triggering the CI should always run a batch of tests. But I realized that some tests can be added and just be bad tests until updated. Or if we want to verify a flaky test in the CI. So instead of only making it additional tests, the spec input will complete replace the default tests (unless you append to the default). Empty will run the default spec still. This will append on to the PR comment with the spec that was run. So at least maintainers can see it passed for a set of tests but it did not run the ones we usually run. Also adding some formatting for empty values for the PR comment. Issue related: opensearch-project#4019 Signed-off-by: Kawika Avilla <[email protected]>
* Basic working version of OSD without angular (opensearch-project#4982) Signed-off-by: Ashwin P Chandran <[email protected]> * [Data Explorer][Discover 2.0] Implement saved search embeddable (opensearch-project#5081) * [Data Explorer][Discover 2.0] Implement saved search embeddable Issue Resolve opensearch-project#4233 --------- Signed-off-by: ananzh <[email protected]> * Deangular: removes angular paginate, cleanup data plugin and tilemap (opensearch-project#5060) Signed-off-by: Ashwin P Chandran <[email protected]> * [Data Explorer] Delete legacy discover selenium tests (opensearch-project#5088) * delete legacy discover functional tests Signed-off-by: abbyhu2000 <[email protected]> * remove discover folder in config file Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> * [Data Explorer][Discover][Function Test] Fix ciGroup4 (opensearch-project#5099) * add data-render-complete and data-shared-item for test convenience * change docTableFieldCount to dataGridTableCellCount to fetch data grid cell * add methods in data grid service to reuse current massive selenium tests * update tests Issue Resolve opensearch-project#5098 opensearch-project#5058 Signed-off-by: Anan Zhuang <[email protected]> * [Data Explorer][Discover][Functional Test] fix ciGroup 8 (opensearch-project#5104) Update index pattern fetch method in discover page due to changing to EuiComboBox. Issue Resolve opensearch-project#5103 Signed-off-by: Anan Zhuang <[email protected]> * Fix cigroup 1 with dataGridTable helper functions (opensearch-project#5105) * fix1 Signed-off-by: abbyhu2000 <[email protected]> * fix 1 Signed-off-by: abbyhu2000 <[email protected]> * fix anchor test Signed-off-by: abbyhu2000 <[email protected]> * fix cigroup1 Signed-off-by: abbyhu2000 <[email protected]> * address comments Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> * [Data Explorer] Fix functional cigroup 3 for save search on dashboard filtering (opensearch-project#5111) * fix cigroup3 Signed-off-by: abbyhu2000 <[email protected]> * fix error Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> * add data-shared-item tag (opensearch-project#5119) Signed-off-by: abbyhu2000 <[email protected]> * Modifying html tests to utilize jsx and fixing tests to include all pluginPaths (opensearch-project#5080) Signed-off-by: Zashary Maskus-Lavin <[email protected]> * fix cigroup6 (opensearch-project#5125) Signed-off-by: abbyhu2000 <[email protected]> * [Discover] Search on load fix (opensearch-project#5112) * fixes search on load Signed-off-by: Ashwin P Chandran <[email protected]> * Fixes search after initial page load Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> * [Data Explorer][Discover][Functional Test] Fix ciGroup7 (opensearch-project#5131) * [Data Explorer][Discover][Functional Test] Fix ciGroup7 Issue Resolve opensearch-project#5129 Signed-off-by: Anan Zhuang <[email protected]> * restore _discover_navigation Signed-off-by: Anan Zhuang <[email protected]> --------- Signed-off-by: Anan Zhuang <[email protected]> * Deangular: removes angular from notify and utils of opendashboards legacy (opensearch-project#5085) * Basic working version of OSD without angular (opensearch-project#4982) Signed-off-by: Ashwin P Chandran <[email protected]> * deangularized notify and utils folders in the opendashboards legacy directory Signed-off-by: Cameron Reed <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: Cameron Reed <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]> Co-authored-by: Cameron Reed <[email protected]> * [Discover] Misc fixes (opensearch-project#5114) * Canvas scrolling fix, remove notice and improve flyout focus Signed-off-by: Ashwin P Chandran <[email protected]> * Hide action icons unless hovered or focussed on Signed-off-by: Ashwin P Chandran <[email protected]> * followup fixes from opensearch-project#5085 Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: ananzh <[email protected]> Signed-off-by: abbyhu2000 <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> Signed-off-by: Zashary Maskus-Lavin <[email protected]> Signed-off-by: Cameron Reed <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> Co-authored-by: Qingyang(Abby) Hu <[email protected]> Co-authored-by: Zashary Maskus-Lavin <[email protected]> Co-authored-by: Cameron Reed <[email protected]> Co-authored-by: Cameron Reed <[email protected]>
…h-project#5172) Set env variable of NODE_OPTIONS for OSD to reference on startup to ensure stable env. Disable threshold enabled for disk allocation Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Matt Provost <[email protected]>
… `https://ip` in `opensearch.hosts` (opensearch-project#4949) The `elasticsearch` client uses a flaws version that incorrectly sets `servername` on a `tls` connection using IPs. Signed-off-by: Miki <[email protected]> Signed-off-by: Josh Romero <[email protected]> Co-authored-by: Josh Romero <[email protected]>
…ject#5130) * Improve testing of clients with long numerals support * Work around serializer inheritance in the JS client Signed-off-by: Miki <[email protected]>
…o embeddable (opensearch-project#5160) * all reload to force update embeddable * add onQuerySubmit to top nav Issue Resolve opensearch-project#5116 opensearch-project#5159 Signed-off-by: ananzh <[email protected]> Co-authored-by: Miki <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]>
Signed-off-by: abbyhu2000 <[email protected]> Co-authored-by: Miki <[email protected]> Co-authored-by: Josh Romero <[email protected]>
* Discover: Fixes state persistence after nav * Fixed breadcrumbs and navigation * fixes mobile view --------- Signed-off-by: Ashwin P Chandran <[email protected]>
…index pattern (opensearch-project#5171) * [BUG][Data Explorer][Discover] Automatically load solo added default index pattern This fix ensures that when add a default index pattern, Discover will automatically select and load its details. Issue Resolve opensearch-project#5128 --------- Signed-off-by: ananzh <[email protected]>
…sed on fetched data count (opensearch-project#5191) * This PR adds a new rows state to the DiscoverCanvas component and updated it whenever the data$ observable emitted new row data. * The DiscoverTable component was then refactored to accept rows as a prop, making it dependent on the parent component to provide the correct set of data. This ensures that the table renders correctly based on the current data and doesn't rely on its internal state, which could be outdated. Issue Resolve opensearch-project#5181 Signed-off-by: ananzh <[email protected]>
…`SavedObject` API (opensearch-project#5190) Fixes opensearch-project#5187 Signed-off-by: Miki <[email protected]>
…ject#5196) Signed-off-by: abbyhu2000 <[email protected]>
opensearch-project#5134 Incorrectly uses the source of the code to pull down to BASE REF, which would likely be `main` or `2.x`, etc. It should be pulling down the PR branch. Cypress tests at the time of merging were failing due to unrelated issue of disk allocation. Not setting the env variables causes the workflow to rely on the default values which is a return back to the original implementation and if the env is set then it will be not empty. Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Ashwin P Chandran <[email protected]>
…fresh page or paste url to a new tab (opensearch-project#5206) Issue Resolve opensearch-project#5179 opensearch-project#5071 Signed-off-by: ananzh <[email protected]>
Signed-off-by: Ashwin P Chandran <[email protected]>
…oject#5213) Signed-off-by: Miki <[email protected]>
* fix time conversion test bug * Fix wrong test case --------- Signed-off-by: Thanh <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> Signed-off-by: Miki <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> Co-authored-by: Miki <[email protected]> Co-authored-by: Sean Neumann <[email protected]>
…e tests (opensearch-project#5221) * remove angular-based view from DocViewsPlugin * remove the test case that validates the display and content of the angular doc view Issue Resolve opensearch-project#5020 Signed-off-by: ananzh <[email protected]>
* removed ftr test step from PR template Signed-off-by: Leo Deng <[email protected]> * change changelog Signed-off-by: Leo Deng <[email protected]> * Update CHANGELOG.md Co-authored-by: Josh Romero <[email protected]> Signed-off-by: Leo Deng <[email protected]> --------- Signed-off-by: Leo Deng <[email protected]> Signed-off-by: Leo Deng <[email protected]> Co-authored-by: Josh Romero <[email protected]>
…ject#5167) * initial commit for datasource Signed-off-by: Eric <[email protected]> * initial commit for datasource service Signed-off-by: Eric <[email protected]> * [Data Sources] Move datasource codebase from datasource plugin to data plugin Signed-off-by: Eric <[email protected]> * [Data Sources] Add datasource factory Signed-off-by: Eric <[email protected]> * datasource service Signed-off-by: Eric <[email protected]> * datasource with factory Signed-off-by: Eric <[email protected]> * datasource selector Signed-off-by: Eric <[email protected]> * exposes datasources from data plugin Signed-off-by: Eric <[email protected]> * index pattern datasource registration Signed-off-by: Eric <[email protected]> * add datasource selector to discover Signed-off-by: Eric <[email protected]> * remove unused files Signed-off-by: Eric <[email protected]> * add/exposes types for datasources as a set of services Signed-off-by: Eric <[email protected]> * add datasource selector unit tests Signed-off-by: Eric <[email protected]> * add metadata to selectable Signed-off-by: Eric <[email protected]> * redirection to observability for non-index-pattern datasource Signed-off-by: Eric <[email protected]> * add datasource factory tests Signed-off-by: Eric <[email protected]> * add datasource service test Signed-off-by: Eric <[email protected]> * datasources related fixes Signed-off-by: Eric <[email protected]> * add tests for datasource selectable Signed-off-by: Eric <[email protected]> * added types/interfaces for sidebar selector, and add a couple of enhancements Signed-off-by: Eric <[email protected]> * remove pill effect Signed-off-by: Eric <[email protected]> * change type for name display in selector for index patterns Signed-off-by: Eric <[email protected]> * remove legacy index selector Signed-off-by: Eric <[email protected]> * rename datasource change handler Signed-off-by: Eric <[email protected]> * remove unused constants Signed-off-by: Eric <[email protected]> * fix a redirection bug Signed-off-by: Eric <[email protected]> * add to change log Signed-off-by: Eric <[email protected]> * fix bg color issue in source selector Signed-off-by: Eric <[email protected]> * address oui and missing guard Signed-off-by: Eric <[email protected]> * add test subj Signed-off-by: Eric <[email protected]> * i18 and datasource interface default return Signed-off-by: Eric <[email protected]> * add default datasource tests Signed-off-by: Eric <[email protected]> * fix typo Signed-off-by: Eric <[email protected]> * modify wording Signed-off-by: Eric <[email protected]> * add experimental annotation to datasource Signed-off-by: Eric <[email protected]> * add type datasource filtering to remove type error hint Signed-off-by: Eric <[email protected]> * remove unused type Signed-off-by: Eric <[email protected]> * add 'type' to option type Signed-off-by: Eric <[email protected]> * Type fixes Signed-off-by: Ashwin P Chandran <[email protected]> * cherry-pick type changes from remote and add partial fixes Signed-off-by: Eric <[email protected]> * add one type exports Signed-off-by: Eric <[email protected]> * remaining type errors fixed Signed-off-by: Ashwin P Chandran <[email protected]> * addressing comments Signed-off-by: Eric <[email protected]> * address dedup Signed-off-by: Eric <[email protected]> * refactor datasource_selectable to address comments Signed-off-by: Joshua Li <[email protected]> * remove unnecessary optional chaining Signed-off-by: Joshua Li <[email protected]> * refactor variable names Signed-off-by: Joshua Li <[email protected]> * move functnions out of selectable component Signed-off-by: Eric <[email protected]> * add comments for dedup/options list updates Signed-off-by: Eric <[email protected]> * add experimental annotation Signed-off-by: Eric <[email protected]> * callback and experimental annotation on types Signed-off-by: Eric <[email protected]> * handleSourceSelection callback Signed-off-by: Eric <[email protected]> * datasource annotation and import adjustment Signed-off-by: Eric <[email protected]> * remove pill effect Signed-off-by: Eric <[email protected]> * minor changes addressing latest comments Signed-off-by: Eric <[email protected]> * remove unused tests Signed-off-by: Eric <[email protected]> --------- Signed-off-by: Eric <[email protected]> Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: Joshua Li <[email protected]> Co-authored-by: Josh Romero <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]> Co-authored-by: Joshua Li <[email protected]>
SuZhou-Joe
changed the base branch from
feature/workspace-service-core-module
to
main
The core workspace module(WorkspaceService) is a foundational component that enables the implementation of workspace features within OSD plugins. The purpose of the core workspace module is to provide a framework for workspace implementations. This module does not implement specific workspace functionality but provides the essential infrastructure for plugins to extend and customize workspace features, it maintains a shared workspace state(observables) across the entire application to ensure a consistent and up-to-date view of workspace-related information to all parts of the application. --------- Signed-off-by: Yulong Ruan <[email protected]>
Signed-off-by: Yulong Ruan <[email protected]>
Signed-off-by: Yulong Ruan <[email protected]>
Signed-off-by: Yulong Ruan <[email protected]>
Signed-off-by: Yulong Ruan <[email protected]>
Co-authored-by: Miki <[email protected]> Signed-off-by: Yulong Ruan <[email protected]> Signed-off-by: Yulong Ruan <[email protected]>
Signed-off-by: Yulong Ruan <[email protected]>
Signed-off-by: Yulong Ruan <[email protected]>
Signed-off-by: Yulong Ruan <[email protected]>
Signed-off-by: Yulong Ruan <[email protected]>
* Discover: Fixes state persistence after nav * Fixed breadcrumbs and navigation * fixes mobile view --------- Signed-off-by: Ashwin P Chandran <[email protected]>
Signed-off-by: SuZhoue-Joe <[email protected]>
Signed-off-by: SuZhoue-Joe <[email protected]>
Signed-off-by: SuZhoue-Joe <[email protected]>
Signed-off-by: SuZhoue-Joe <[email protected]>
Signed-off-by: SuZhoue-Joe <[email protected]>
Signed-off-by: SuZhoue-Joe <[email protected]>
Signed-off-by: SuZhoue-Joe <[email protected]>
Signed-off-by: SuZhoue-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
SuZhou-Joe
force-pushed
the
feature/stateful_url_hash
branch
from
ce64684 to
05fda74
Compare
Codecov Report
@@ Coverage Diff @@
## main #209 +/- ##
=======================================
Coverage ? 66.79%
=======================================
Files ? 3286
Lines ? 63126
Branches ? 10052
=======================================
Hits ? 42166
Misses ? 18487
Partials ? 2473
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
Screenshot
Testing the changes
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr