forked from opensearch-project/OpenSearch-Dashboards
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register Advance Settings, Data Source management,Index Pattern management and SavedObject management as standalone app, retire dashboard management #208
Merged
raintygao
merged 16 commits into
ruanyl:workspace-pr-integr
from
raintygao:feat-register-category
Oct 10, 2023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tygao <[email protected]>
* move index pattern to libaray Signed-off-by: Hailong Cui <[email protected]> * Remove it from Dashboards management when workspace is on Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]> index pattern always show under library Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
… out of Dashboard management Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
move data source / advanced settings / saved objects management out of Dashboard management
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Codecov Report
@@ Coverage Diff @@
## workspace-pr-integr #208 +/- ##
=======================================================
+ Coverage 66.46% 66.48% +0.01%
=======================================================
Files 3408 3412 +4
Lines 65148 65234 +86
Branches 10430 10456 +26
=======================================================
+ Hits 43303 43370 +67
- Misses 19227 19260 +33
+ Partials 2618 2604 -14
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 36 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: tygao <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
wanglam
reviewed
Oct 7, 2023
src/plugins/advanced_settings/public/management_app/components/page_wrapper/page_wrapper.tsx
Show resolved
Hide resolved
src/plugins/advanced_settings/public/management_app/mount_management_section.tsx
Outdated
Show resolved
Hide resolved
src/plugins/data_source_management/public/components/page_wrapper/page_wrapper.tsx
Outdated
Show resolved
Hide resolved
src/plugins/saved_objects_management/public/management_section/mount_section.tsx
Show resolved
Hide resolved
src/plugins/saved_objects_management/public/management_section/page_wrapper/page_wrapper.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
wanglam
approved these changes
Oct 8, 2023
Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: tygao <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
wanglam
pushed a commit
that referenced
this pull request
Feb 26, 2024
…ement and SavedObject management as standalone app, retire dashboard management (#208) * feat: init retire dashboard management Signed-off-by: tygao <[email protected]> * move index pattern to Library (#91) * move index pattern to libaray Signed-off-by: Hailong Cui <[email protected]> * Remove it from Dashboards management when workspace is on Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]> index pattern always show under library Signed-off-by: Hailong Cui <[email protected]> * functional test Signed-off-by: Hailong Cui <[email protected]> * feat: move data source / advanced settings / saved objects management out of Dashboard management Signed-off-by: SuZhou-Joe <[email protected]> * feat: update test Signed-off-by: SuZhou-Joe <[email protected]> * feat: update snapshot Signed-off-by: SuZhou-Joe <[email protected]> * feat: update snapshot Signed-off-by: SuZhou-Joe <[email protected]> * fix: fix failed overview header ut Signed-off-by: tygao <[email protected]> * fix: deeplink inside saved objects management page Signed-off-by: SuZhou-Joe <[email protected]> * fix: unit test fail Signed-off-by: SuZhou-Joe <[email protected]> * feat: add unit test for each page wrapper Signed-off-by: SuZhou-Joe <[email protected]> * feat: some optimization Signed-off-by: SuZhou-Joe <[email protected]> * remove management dependency Signed-off-by: Hailong Cui <[email protected]> * test: update cypress config to use workspace branch Signed-off-by: tygao <[email protected]> * Replace ManagementAppMountParams with AppMountParameters Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: tygao <[email protected]> Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: Hailong Cui <[email protected]> Co-authored-by: SuZhou-Joe <[email protected]>
7 tasks
ruanyl
added a commit
that referenced
this pull request
Mar 7, 2024
…n management and SavedObject management as standalone app, retire dashboard management (#283) * Revert "Register Advance Settings, Data Source management,Index Pattern management and SavedObject management as standalone app, retire dashboard management (#208)" This reverts commit 5f09f84. * Revert "feat: add unit test for mountWrapper (#223)" This reverts commit a70ce71. * Revert "fix: cypress tests checkout workspace branch (#252)" This reverts commit 734c890. * run cypress with ftr main Signed-off-by: Yulong Ruan <[email protected]> --------- Signed-off-by: Yulong Ruan <[email protected]>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Mar 11, 2024
…n management and SavedObject management as standalone app, retire dashboard management (#283) * Revert "Register Advance Settings, Data Source management,Index Pattern management and SavedObject management as standalone app, retire dashboard management (#208)" This reverts commit 5f09f84. * Revert "feat: add unit test for mountWrapper (#223)" This reverts commit a70ce71. * Revert "fix: cypress tests checkout workspace branch (#252)" This reverts commit 734c890. * run cypress with ftr main Signed-off-by: Yulong Ruan <[email protected]> --------- Signed-off-by: Yulong Ruan <[email protected]>
SuZhou-Joe
added a commit
that referenced
this pull request
Mar 18, 2024
…ement and SavedObject management as standalone app, retire dashboard management (#208) * feat: init retire dashboard management Signed-off-by: tygao <[email protected]> * move index pattern to Library (#91) * move index pattern to libaray Signed-off-by: Hailong Cui <[email protected]> * Remove it from Dashboards management when workspace is on Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]> index pattern always show under library Signed-off-by: Hailong Cui <[email protected]> * functional test Signed-off-by: Hailong Cui <[email protected]> * feat: move data source / advanced settings / saved objects management out of Dashboard management Signed-off-by: SuZhou-Joe <[email protected]> * feat: update test Signed-off-by: SuZhou-Joe <[email protected]> * feat: update snapshot Signed-off-by: SuZhou-Joe <[email protected]> * feat: update snapshot Signed-off-by: SuZhou-Joe <[email protected]> * fix: fix failed overview header ut Signed-off-by: tygao <[email protected]> * fix: deeplink inside saved objects management page Signed-off-by: SuZhou-Joe <[email protected]> * fix: unit test fail Signed-off-by: SuZhou-Joe <[email protected]> * feat: add unit test for each page wrapper Signed-off-by: SuZhou-Joe <[email protected]> * feat: some optimization Signed-off-by: SuZhou-Joe <[email protected]> * remove management dependency Signed-off-by: Hailong Cui <[email protected]> * test: update cypress config to use workspace branch Signed-off-by: tygao <[email protected]> * Replace ManagementAppMountParams with AppMountParameters Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: tygao <[email protected]> Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: Hailong Cui <[email protected]> Co-authored-by: SuZhou-Joe <[email protected]>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Mar 18, 2024
…n management and SavedObject management as standalone app, retire dashboard management (#283) * Revert "Register Advance Settings, Data Source management,Index Pattern management and SavedObject management as standalone app, retire dashboard management (#208)" This reverts commit 5f09f84. * Revert "feat: add unit test for mountWrapper (#223)" This reverts commit a70ce71. * Revert "fix: cypress tests checkout workspace branch (#252)" This reverts commit 734c890. * run cypress with ftr main Signed-off-by: Yulong Ruan <[email protected]> --------- Signed-off-by: Yulong Ruan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
Screenshot
Testing the changes
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr