Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register Advance Settings, Data Source management,Index Pattern management and SavedObject management as standalone app, retire dashboard management #208

Merged
merged 16 commits into from
Oct 10, 2023

Conversation

raintygao
Copy link
Collaborator

Description

  1. Register Advance Settings, Data Source management, Index Pattern management and SavedObject management as standalone app
  2. Retire dashboard management

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

raintygao and others added 6 commits September 28, 2023 10:56
* move index pattern to libaray

Signed-off-by: Hailong Cui <[email protected]>

* Remove it from Dashboards management when workspace is on

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>

index pattern always show under library

Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
… out of Dashboard management

Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
move data source / advanced settings / saved objects management out of Dashboard management
@raintygao raintygao marked this pull request as draft September 28, 2023 09:03
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2023

Codecov Report

Merging #208 (75cdf70) into workspace-pr-integr (5bc2ddf) will increase coverage by 0.01%.
Report is 1 commits behind head on workspace-pr-integr.
The diff coverage is 61.29%.

@@                   Coverage Diff                   @@
##           workspace-pr-integr     #208      +/-   ##
=======================================================
+ Coverage                66.46%   66.48%   +0.01%     
=======================================================
  Files                     3408     3412       +4     
  Lines                    65148    65234      +86     
  Branches                 10430    10456      +26     
=======================================================
+ Hits                     43303    43370      +67     
- Misses                   19227    19260      +33     
+ Partials                  2618     2604      -14     
Flag Coverage Δ
Linux_ 66.06% <61.29%> (+0.01%) ⬆️
_1 34.82% <26.31%> (+<0.01%) ⬆️
_2 55.45% <0.00%> (?)
_3 44.50% <44.44%> (-0.09%) ⬇️
_4 34.84% <55.55%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/core/public/core_app/errors/url_overflow.tsx 88.23% <ø> (ø)
...rc/core/public/core_app/errors/url_overflow_ui.tsx 66.66% <ø> (ø)
...re/server/ui_settings/saved_objects/ui_settings.ts 33.33% <ø> (ø)
...ement_app/components/page_wrapper/page_wrapper.tsx 100.00% <100.00%> (ø)
...nt/public/components/page_wrapper/page_wrapper.tsx 100.00% <100.00%> (ø)
src/plugins/data_source_management/public/types.ts 100.00% <ø> (ø)
...plication/components/top_nav/open_search_panel.tsx 28.57% <ø> (ø)
...pplication/components/top_nav/open_search_panel.js 57.14% <ø> (ø)
.../public/application/components/new_theme_modal.tsx 33.33% <ø> (ø)
...lic/components/getting_started/getting_started.tsx 85.71% <ø> (ø)
... and 14 more

... and 36 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@SuZhou-Joe SuZhou-Joe marked this pull request as ready for review September 29, 2023 00:53
@raintygao raintygao merged commit 87c0c8a into ruanyl:workspace-pr-integr Oct 10, 2023
32 checks passed
wanglam pushed a commit that referenced this pull request Feb 26, 2024
…ement and SavedObject management as standalone app, retire dashboard management (#208)

* feat: init retire dashboard management

Signed-off-by: tygao <[email protected]>

* move index pattern to Library (#91)

* move index pattern to libaray

Signed-off-by: Hailong Cui <[email protected]>

* Remove it from Dashboards management when workspace is on

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>

index pattern always show under library

Signed-off-by: Hailong Cui <[email protected]>

* functional test

Signed-off-by: Hailong Cui <[email protected]>

* feat: move data source / advanced settings / saved objects management out of Dashboard management

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update test

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update snapshot

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update snapshot

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: fix failed overview header ut

Signed-off-by: tygao <[email protected]>

* fix: deeplink inside saved objects management page

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: unit test fail

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add unit test for each page wrapper

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: some optimization

Signed-off-by: SuZhou-Joe <[email protected]>

* remove management dependency

Signed-off-by: Hailong Cui <[email protected]>

* test: update cypress config to use workspace branch

Signed-off-by: tygao <[email protected]>

* Replace ManagementAppMountParams with AppMountParameters

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: tygao <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Co-authored-by: Hailong Cui <[email protected]>
Co-authored-by: SuZhou-Joe <[email protected]>
ruanyl added a commit that referenced this pull request Mar 6, 2024
…rn management and SavedObject management as standalone app, retire dashboard management (#208)"

This reverts commit 5f09f84.
ruanyl added a commit that referenced this pull request Mar 7, 2024
…n management and SavedObject management as standalone app, retire dashboard management (#283)

* Revert "Register Advance Settings, Data Source management,Index Pattern management and SavedObject management as standalone app, retire dashboard management (#208)"

This reverts commit 5f09f84.

* Revert "feat: add unit test for mountWrapper (#223)"

This reverts commit a70ce71.

* Revert "fix: cypress tests checkout workspace branch (#252)"

This reverts commit 734c890.

* run cypress with ftr main

Signed-off-by: Yulong Ruan <[email protected]>

---------

Signed-off-by: Yulong Ruan <[email protected]>
SuZhou-Joe pushed a commit that referenced this pull request Mar 11, 2024
…n management and SavedObject management as standalone app, retire dashboard management (#283)

* Revert "Register Advance Settings, Data Source management,Index Pattern management and SavedObject management as standalone app, retire dashboard management (#208)"

This reverts commit 5f09f84.

* Revert "feat: add unit test for mountWrapper (#223)"

This reverts commit a70ce71.

* Revert "fix: cypress tests checkout workspace branch (#252)"

This reverts commit 734c890.

* run cypress with ftr main

Signed-off-by: Yulong Ruan <[email protected]>

---------

Signed-off-by: Yulong Ruan <[email protected]>
SuZhou-Joe added a commit that referenced this pull request Mar 18, 2024
…ement and SavedObject management as standalone app, retire dashboard management (#208)

* feat: init retire dashboard management

Signed-off-by: tygao <[email protected]>

* move index pattern to Library (#91)

* move index pattern to libaray

Signed-off-by: Hailong Cui <[email protected]>

* Remove it from Dashboards management when workspace is on

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>

index pattern always show under library

Signed-off-by: Hailong Cui <[email protected]>

* functional test

Signed-off-by: Hailong Cui <[email protected]>

* feat: move data source / advanced settings / saved objects management out of Dashboard management

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update test

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update snapshot

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update snapshot

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: fix failed overview header ut

Signed-off-by: tygao <[email protected]>

* fix: deeplink inside saved objects management page

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: unit test fail

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add unit test for each page wrapper

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: some optimization

Signed-off-by: SuZhou-Joe <[email protected]>

* remove management dependency

Signed-off-by: Hailong Cui <[email protected]>

* test: update cypress config to use workspace branch

Signed-off-by: tygao <[email protected]>

* Replace ManagementAppMountParams with AppMountParameters

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: tygao <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Co-authored-by: Hailong Cui <[email protected]>
Co-authored-by: SuZhou-Joe <[email protected]>
SuZhou-Joe pushed a commit that referenced this pull request Mar 18, 2024
…n management and SavedObject management as standalone app, retire dashboard management (#283)

* Revert "Register Advance Settings, Data Source management,Index Pattern management and SavedObject management as standalone app, retire dashboard management (#208)"

This reverts commit 5f09f84.

* Revert "feat: add unit test for mountWrapper (#223)"

This reverts commit a70ce71.

* Revert "fix: cypress tests checkout workspace branch (#252)"

This reverts commit 734c890.

* run cypress with ftr main

Signed-off-by: Yulong Ruan <[email protected]>

---------

Signed-off-by: Yulong Ruan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants