[Backport workspace]Patch/first pr (#194) #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## workspace #196 +/- ##
=============================================
- Coverage 66.12% 66.12% -0.01%
=============================================
Files 3420 3420
Lines 65753 65753
Branches 10590 10590
=============================================
- Hits 43479 43477 -2
- Misses 19633 19634 +1
- Partials 2641 2642 +1
Flags with carried forward coverage won't be shown. Click here to find out more. see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@SuZhou-Joe It looks some tests are failed |
Indeed, it is due to:
|
SuZhou-Joe
force-pushed
the
backport/backport-194-to-workspace
branch
from
cd670a2 to
838e966
Compare
ruanyl
approved these changes
Oct 8, 2023
* temp: add unit test Signed-off-by: SuZhou-Joe <[email protected]> * feat: add function test for workspace CRUD routes Signed-off-by: SuZhou-Joe <[email protected]> * feat: use saved objects client instead of internal repository Signed-off-by: SuZhou-Joe <[email protected]> * feat: update CHANGELOG Signed-off-by: SuZhou-Joe <[email protected]> * feat: exclude permission check wrapper Signed-off-by: SuZhou-Joe <[email protected]> * feat: add integration test Signed-off-by: SuZhou-Joe <[email protected]> * feat: add configuration Signed-off-by: SuZhou-Joe <[email protected]> * feat: enable workspace flag when run workspace related test Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
SuZhou-Joe
force-pushed
the
backport/backport-194-to-workspace
branch
from
2e2b9fb to
86fcb49
Compare
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
temp: add unit test
feat: add function test for workspace CRUD routes
feat: use saved objects client instead of internal repository
feat: update CHANGELOG
feat: exclude permission check wrapper
feat: add integration test
feat: add configuration
feat: enable workspace flag when run workspace related test
Description
Issues Resolved
Screenshot
Testing the changes
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr