remove hide import

Signed-off-by: Hailong Cui <[email protected]>
ruanyl · Mar 8, 2024 · 448fdb2 · 448fdb2
1 parent 740479d
commit 448fdb2
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 44 deletions.
diff --git a/...t/public/management_section/objects_table/__snapshots__/saved_objects_table.test.tsx.snap b/...t/public/management_section/objects_table/__snapshots__/saved_objects_table.test.tsx.snap
diff --git a/...ved_objects_management/public/management_section/objects_table/components/header.test.tsx b/...ved_objects_management/public/management_section/objects_table/components/header.test.tsx
@@ -40,29 +40,10 @@ describe('Header', () => {
       onRefresh: () => {},
       totalCount: 4,
       filteredCount: 2,
-      title: '',
     };
 
     const component = shallow(<Header {...props} />);
 
     expect(component).toMatchSnapshot();
   });
 });
-
-describe('Header - workspace enabled', () => {
-  it('should hide `Import` button for application home state', () => {
-    const props = {
-      onExportAll: () => {},
-      onImport: () => {},
-      onRefresh: () => {},
-      totalCount: 4,
-      filteredCount: 2,
-      hideImport: true,
-      title: 'Saved Objectes',
-    };
-
-    const component = shallow(<Header {...props} />);
-
-    expect(component.find('EuiButtonEmpty[data-test-subj="importObjects"]').exists()).toBe(false);
-  });
-});
diff --git a/...ns/saved_objects_management/public/management_section/objects_table/components/header.tsx b/...ns/saved_objects_management/public/management_section/objects_table/components/header.tsx
@@ -45,15 +45,11 @@ export const Header = ({
   onImport,
   onRefresh,
   filteredCount,
-  hideImport,
-  title,
 }: {
   onExportAll: () => void;
   onImport: () => void;
   onRefresh: () => void;
   filteredCount: number;
-  hideImport?: boolean;
-  title: string;
 }) => (
   <Fragment>
     <EuiFlexGroup justifyContent="spaceBetween" alignItems="baseline">
@@ -86,21 +82,19 @@ export const Header = ({
               />
             </EuiButtonEmpty>
           </EuiFlexItem>
-          {!hideImport && (
-            <EuiFlexItem grow={false}>
-              <EuiButtonEmpty
-                size="s"
-                iconType="importAction"
-                data-test-subj="importObjects"
-                onClick={onImport}
-              >
-                <FormattedMessage
-                  id="savedObjectsManagement.objectsTable.header.importButtonLabel"
-                  defaultMessage="Import"
-                />
-              </EuiButtonEmpty>
-            </EuiFlexItem>
-          )}
+          <EuiFlexItem grow={false}>
+            <EuiButtonEmpty
+              size="s"
+              iconType="importAction"
+              data-test-subj="importObjects"
+              onClick={onImport}
+            >
+              <FormattedMessage
+                id="savedObjectsManagement.objectsTable.header.importButtonLabel"
+                defaultMessage="Import"
+              />
+            </EuiButtonEmpty>
+          </EuiFlexItem>
           <EuiFlexItem grow={false}>
             <EuiButtonEmpty size="s" iconType="refresh" onClick={onRefresh}>
               <FormattedMessage

diff --git a/.../saved_objects_management/public/management_section/objects_table/saved_objects_table.tsx b/.../saved_objects_management/public/management_section/objects_table/saved_objects_table.tsx
@@ -992,9 +992,6 @@ export class SavedObjectsTable extends Component<SavedObjectsTableProps, SavedOb
       });
     }
 
-    // workspace enable and no workspace is selected
-    const hideImport = workspaceEnabled && !currentWorkspaceId;
-
     return (
       <EuiPageContent horizontalPosition="center">
         {this.renderFlyout()}
@@ -1006,8 +1003,6 @@ export class SavedObjectsTable extends Component<SavedObjectsTableProps, SavedOb
           onImport={this.showImportFlyout}
           onRefresh={this.refreshObjects}
           filteredCount={filteredItemCount}
-          hideImport={hideImport}
-          title={this.props.title}
         />
         <EuiSpacer size="xs" />
         <RedirectAppLinks application={applications}>