-
Notifications
You must be signed in to change notification settings - Fork 80
Update processing for current gem versions [fny] #92
base: master
Are you sure you want to change the base?
Conversation
Add specific loading sequence for each gem to fix current errors
Apologies if a pull request was inappropriate. I'm fairly new to the git workflow. There are still some encoding and output comparison errors when running the tests. However, loading issues have been resolved and the doc output looks fine. From the nature of the output errors, I'm assuming that the tests need to be updated to compare output specific to the current gem versions as well. Object instantiation is made specific to each library as opposed to the current generalization currently employed in Note I did not stage an updated gemspec. Also, I considered adding a means to load a different gem if the output failed to produce HTML, but time didn't permit. Here's some shoddy, cumbersome pseudocode: md_factories = [{
:library=> 'gem',
:processor=>"Library.new(text).to_html"
},
{
...
}
]
for i in md_factory do
if gem_available?
require 'gem'
text="sample"
mdf = eval md_factories[:processor]
break if mdf.class == String
end
raise 'All libraries failed' if md_factories.empty? TestingThe gem builds without any issues:
Redcarpet
RDiscount
BlueCloth
|
Hotfix to add specific loading sequence for each gem to fix current errors. Documentation will render correctly, however encoding issues and HTML mismatches arise during testing.