Evalg 84 #711
Open
Evalg 84 #711
+56
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcamposruiz
requested changes
Sep 24, 2024
tutorials/docker/Dockerfile
Outdated
| && apt-get update \ | ||
| && apt-get install -y rti-connext-dds-7.3.0 \ | ||
| && apt-get clean \ | ||
| && rm -rf /var/lib/apt/lists | ||
|
|
||
| # For armv8 uncomment the following line | ||
| # ENV CONNEXTDDS_ARCH=armv8Linux4gcc7.3.0 |
There was a problem hiding this comment.
It would be nice to figure out the right CONNEXTDDS_ARCH based on the system's archicteure (for ex. with uname -m)
There was a problem hiding this comment.
I haven't tested this on armv8, this comment was leftover from how the file was before. If everything else looks good, I'll test this part in the lab to see if setting CONNEXTDDS_ARCH is needed and if so, using uname -m or some other cpu command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rewriting the EvalGuide Docker module to use Debian package for creating docker images with Connext installed
Details and comments
-Updated Dockerfile to install packages such as curl, run the basic install commands for Connext
-Updated CmakeList to refer to /app to find cmake files
Checks