Remove cargo xtask doc, only use cargo doc subcommand for book

Add features so everything is actually documented

rtic-monotonics/src/lib.rs

@@ -4,13 +4,19 @@
 //! To enable the implementations, you must enable a feature for the specific MCU you're targeting.
 //!
 //! # Cortex-M Systick
-//! The [`systick`] monotonic works on all cortex-M parts, and requires that the feature `cortex-m-systick` is enabled.
+//! The
+#![cfg_attr(feature = "cortex-m-systick", doc = "[`systick`]")]
+#![cfg_attr(not(feature = "cortex-m-systick"), doc = "`systick`")]
+//! monotonic works on all cortex-M parts, and requires that the feature `cortex-m-systick` is enabled.
 //!
 //! # RP2040
-//! The RP2040 monotonics require that the `rp2040` feature is enabled.
+//! The
+#![cfg_attr(feature = "rp2040", doc = "[`rp2040`]")]
+#![cfg_attr(not(feature = "rp2040"), doc = "`rp2040`")]
+//! monotonics require that the `rp2040` feature is enabled.
 //!
 //! # nRF
-//! nRF monotonics require that one of the available `nrf52*` features is enabled.
+//! The nRF monotonics require that one of the available `nrf52*` features is enabled.
 //!
 //! All implementations of timers for the nRF52 family are documented here. Monotonics that
 //! are not available on all parts in this family will have an `Available on crate features X only`

xtask/src/argument_parsing.rs

@@ -283,14 +283,6 @@ pub enum Commands {
     /// Requires that an ARM target is selected
     Run(QemuAndRun),
 
-    /// Build docs
-    ///
-    /// To pass options to `cargo doc`, add `--` and then the following
-    /// arguments will be passed on
-    ///
-    /// Example: `cargo xtask doc -- --open`
-    Doc(DocArgs),
-
     /// Run tests
     Test(PackageOpt),
 

xtask/src/main.rs

@@ -136,10 +136,6 @@ fn main() -> anyhow::Result<()> {
             let ex = args.examples.example_list()?;
             qemu_run_examples(globals, &cargologlevel, ex, args.overwrite_expected)
         }
-        Commands::Doc(args) => {
-            let links = !args.skip_link_check;
-            cargo_doc(globals, &cargologlevel, &args.arguments, links)
-        }
         Commands::Test(args) => cargo_test(globals, &args),
         Commands::Book(args) => {
             let links = !args.skip_link_check;

xtask/src/run.rs

@@ -344,39 +344,6 @@ pub fn cargo_format<'c>(
     runner.run_and_coalesce()
 }
 
-/// Run cargo doc
-pub fn cargo_doc<'c>(
-    globals: &'c Globals,
-    cargoarg: &'c Option<&'c str>,
-    arguments: &'c Option<ExtraArguments>,
-    check_links: bool,
-) -> Vec<FinalRunResult<'c>> {
-    let backend = globals.backend();
-    info!("Running cargo doc for backend {backend:?}");
-
-    let features = Some(backend.to_target().and_features(backend.to_rtic_feature()));
-
-    let command = CargoCommand::Doc {
-        cargoarg,
-        features,
-        arguments: arguments.clone(),
-        deny_warnings: true,
-    };
-
-    let mut results = Vec::new();
-    let doc = run_and_convert((globals, command, false));
-    results.push(doc);
-    if results.iter().any(|r| !r.is_success()) {
-        return results;
-    }
-
-    if check_links {
-        let mut links = check_all_api_links(globals);
-        results.append(&mut links);
-    }
-    results
-}
-
 /// Run cargo test on the selected package or all packages
 ///
 /// If no package is specified, loop through all packages
@@ -585,9 +552,12 @@ pub fn cargo_book<'c>(
         }
         api
     } else {
+        let features = globals.backend().to_rtic_feature().to_string();
+        let features = format!("rp2040,cortex-m-systick,nrf52840,{features}");
+
         let doc_command = CargoCommand::Doc {
             cargoarg: &None,
-            features: Some(globals.backend().to_rtic_feature().to_string()),
+            features: Some(features),
             arguments: None,
             deny_warnings: true,
         };