Use a new ci style for linux #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pet-mit
requested changes
Sep 12, 2024
Comment on lines
+44
to
+48
| OR_REPO="https://github.com/google/or-tools.git" | ||
| TAGNAME="${{ github.event.release.tag_name }}" | ||
| TAGNAME_WITHOUT_SUFFIX=${TAGNAME%%-*} | ||
| echo "OR_REPO=$OR_REPO" >> $GITHUB_ENV | ||
| echo "OR_REF=$TAGNAME_WITHOUT_SUFFIX" >> $GITHUB_ENV |
There was a problem hiding this comment.
you only need to do this in step "Checkout or-tools if release"
Comment on lines
+46
to
+50
| OR_REPO="https://github.com/google/or-tools.git" | ||
| TAGNAME="${{ github.event.release.tag_name }}" | ||
| TAGNAME_WITHOUT_SUFFIX=${TAGNAME%%-*} | ||
| echo "OR_REPO=$OR_REPO" >> $GITHUB_ENV | ||
| echo "OR_REF=$TAGNAME_WITHOUT_SUFFIX" >> $GITHUB_ENV |
pet-mit
approved these changes
Sep 13, 2024
pet-mit
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
python patch.py, thaks to Feature/cmake project #13, we now use cmake insteadfind pythoninsidecmakelist.txtbecause in some linux distribution onlypython3is available and nopythonunfortunately some interactions of the root cmakelist with ortools cmakelists (I could not solve the issue) forces us to look for Development.Module that is useless for the patch but necessary for ortools
find_package(Python3 REQUIRED COMPONENTS Interpreter Development.Module)stablebranch ofgoogle/ortools, this needs to be changed quickly since the latest version of ortools renamed a file (cmake/deps.cmake->cmake/system_deps.cmake)patchs->cmake_patches