Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/v8.7.0 #224

Merged
merged 44 commits into from
May 28, 2024
Merged

Release/v8.7.0 #224

merged 44 commits into from
May 28, 2024

Conversation

berthetclement
Copy link
Collaborator

@berthetclement berthetclement commented Oct 31, 2023

This branch will contain all the elements needed to upgrade to version 2.7.0.
This release will include the features of Antares simulator v8.7.0 (see Antares simulator changelog).

BERTHET Clement Ext and others added 30 commits April 20, 2023 15:16
Merge branch 'master' of https://github.com/rte-antares-rpackage/antaresRead into dev_86

# Conflicts:
#	NEWS.md
…gConstraints() according to new structure + tests
…ject, tests values and operator, test default values
summary.bindingConstraints add badge "deprecated" for versions >= v2.7.0
fread_antares update to suppress warnings
@berthetclement berthetclement self-assigned this Feb 19, 2024
@berthetclement berthetclement added this to the nextRelease milestone Feb 19, 2024
##
# Exception if no properties
##

if(length(bindingConstraints) == 0) {
warning("It looks like there is no binding constraints is this study.")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eviter le conditionnel et envoyer un warning du style "No binding constraints found in this study" ?

BERTHET Clement (Externe) and others added 5 commits March 18, 2024 16:50
@berthetclement berthetclement changed the base branch from master to develop April 4, 2024 08:23
BERTHET Clement (Externe) and others added 4 commits April 4, 2024 11:13
@berthetclement berthetclement requested a review from vargastat May 28, 2024 08:53
@berthetclement berthetclement merged commit 59cef41 into develop May 28, 2024
6 checks passed
@berthetclement berthetclement deleted the release/v8.7.0 branch May 28, 2024 12:58
Copy link
Collaborator

@vargastat vargastat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok for release

berthetclement added a commit that referenced this pull request Sep 2, 2024
* update github workflow

* Read cluster desc bugfix when cluster exist (#242)

* fix bug readClusterDesc when no cluster + cover ST and RES case

* add test (init test for thermal + res)

* Release/cran261 (#244) (#245)

update with developments made during the CRAN release phase

* Add argument encoding in api_get() (#246)

* Add encoding argument to api_get()

* [readIniFile] : avoid `utils::type.convert` on specific cases (ex : 789e or 123i)  (#247)

* Add specific case to avoid bad convert

* Add unit test file for readIniFile

* Release/v8.7.0 (#224)

### Breaking changes (Antares v8.7.0) : 

* `readBindingConstraints()` read now Scenarized RHS for binding constraints (cf. Antares v8.7 changelog)
  - function returns a new list structure
* Private function `fread_antares()` no longer returns warnings  
* `api_put()/api_delete()` return a server error message 

BUGFIXES :  

* `readBindingConstraints()` read well study >= v8.3.2

DATA : 

* A test study in tar.gz format is available in version v8.7.0  
* An empty test study in version v8.7.0 for marginal cases 

Dependencies :  

* New package `lifecycle` to manage functions status/package status

* Dev readInputThermal, add area parameter + parameter thermalavailabilities + default matrix when no time series in cluster (#243)

* Dev readInputThermal, add area parameter + parameter thermalavailabilities + default matrix when no time series in cluster

* .importThermalData fixed to be compatible with data daily format

* fix test thermal + add test RES

* update

* Ant1777/dimbcgroup (#251)

* setSimulationPath() updated with new private function to add meta data group dimension for binding constraints

* setSimulationPath() doc updated with new parameter

* Read ST clusters with readAntares() (#252)

* Add .importOutputForSTClusters()

* Add 'clustersST' argument in readAntares()

* create a wrapper for calling .reshape_details_file()

* Simplify .get_value_columns_details_file() with a reference table

* Correct areasWithSTClusters parameter in .getSimOptions()

* Add unit tests for 'areasWithSTClusters' parameter

* Add DETAILS_FILES_TYPE column in the simulation_variables_names_by_support.csv

* Update NEWS.md

* Make new parameter 'clustersST' API compatible

* Update documentation with the new function .importOutputForSTClusters()

* Import simulation_variables_names_by_support.csv in data.frame type rather than data.table

* Specify the separator for the simulation_variables_names_by_support.csv import

* Check reverse dependencies

* revdep check ok

* fix rhdf5 call refenrence

* Revdeps ok

* cleaning tests

* add cran-comments

* COMMENT THESE TESTS

* GitHub Actions workflow updated with r-hub v2

* delete package rhdf5 from suggests and delete all functions who use it + delete tests

* cran comment updated with rev dep check ok

* update setsimulation path no more check .h5

* update test to put inside testhat

* comment, cran issue

* update study selection "grep" pattern in tests causing CRAN ISSUE

* add test for path in setSimulationPath() + test + cleaning vignette

* update docs to put values returned + some cleaning references to private function with (:::)

* Fix bad usage of options("warn")

* delete references to .GlobalEnv in test environment

* readAntares() updated to delete `assign` function to modifiy the .GlobalEnv

* delete assign() function and ref to .GlobalEnv

* update cran-comment

* setSimulationPath() delete `getwd()` to choose dir in windows (cran policie)
berthetclement added a commit that referenced this pull request Sep 2, 2024
* Release/cran261 (#244)

* update github workflow

* Read cluster desc bugfix when cluster exist (#242)

* fix bug readClusterDesc when no cluster + cover ST and RES case

* add test (init test for thermal + res)

* cleaning

* fix cran NOTE causing by bad url in doc + bad doc

* Release/cran270 (#249)



### Breaking changes (Antares v8.7.0) : 

* `readBindingConstraints()` read now Scenarized RHS for binding constraints (cf. Antares v8.7 changelog)
  - function returns a new list structure
* Private function `fread_antares()` no longer returns warnings  
* `api_put()/api_delete()` return a server error message 

BUGFIXES :  

* `readBindingConstraints()` read well study >= v8.3.2

DATA : 

* A test study in tar.gz format is available in version v8.7.0  
* An empty test study in version v8.7.0 for marginal cases 

Dependencies :  

* New package `lifecycle` to manage functions status/package status

* Releasecran/271 (#253)

* update github workflow

* Read cluster desc bugfix when cluster exist (#242)

* fix bug readClusterDesc when no cluster + cover ST and RES case

* add test (init test for thermal + res)

* Release/cran261 (#244) (#245)

update with developments made during the CRAN release phase

* Add argument encoding in api_get() (#246)

* Add encoding argument to api_get()

* [readIniFile] : avoid `utils::type.convert` on specific cases (ex : 789e or 123i)  (#247)

* Add specific case to avoid bad convert

* Add unit test file for readIniFile

* Release/v8.7.0 (#224)

### Breaking changes (Antares v8.7.0) : 

* `readBindingConstraints()` read now Scenarized RHS for binding constraints (cf. Antares v8.7 changelog)
  - function returns a new list structure
* Private function `fread_antares()` no longer returns warnings  
* `api_put()/api_delete()` return a server error message 

BUGFIXES :  

* `readBindingConstraints()` read well study >= v8.3.2

DATA : 

* A test study in tar.gz format is available in version v8.7.0  
* An empty test study in version v8.7.0 for marginal cases 

Dependencies :  

* New package `lifecycle` to manage functions status/package status

* Dev readInputThermal, add area parameter + parameter thermalavailabilities + default matrix when no time series in cluster (#243)

* Dev readInputThermal, add area parameter + parameter thermalavailabilities + default matrix when no time series in cluster

* .importThermalData fixed to be compatible with data daily format

* fix test thermal + add test RES

* update

* Ant1777/dimbcgroup (#251)

* setSimulationPath() updated with new private function to add meta data group dimension for binding constraints

* setSimulationPath() doc updated with new parameter

* Read ST clusters with readAntares() (#252)

* Add .importOutputForSTClusters()

* Add 'clustersST' argument in readAntares()

* create a wrapper for calling .reshape_details_file()

* Simplify .get_value_columns_details_file() with a reference table

* Correct areasWithSTClusters parameter in .getSimOptions()

* Add unit tests for 'areasWithSTClusters' parameter

* Add DETAILS_FILES_TYPE column in the simulation_variables_names_by_support.csv

* Update NEWS.md

* Make new parameter 'clustersST' API compatible

* Update documentation with the new function .importOutputForSTClusters()

* Import simulation_variables_names_by_support.csv in data.frame type rather than data.table

* Specify the separator for the simulation_variables_names_by_support.csv import

* Check reverse dependencies

* revdep check ok

* fix rhdf5 call refenrence

* Revdeps ok

* cleaning tests

* add cran-comments

* COMMENT THESE TESTS

* GitHub Actions workflow updated with r-hub v2

* delete package rhdf5 from suggests and delete all functions who use it + delete tests

* cran comment updated with rev dep check ok

* update setsimulation path no more check .h5

* update test to put inside testhat

* comment, cran issue

* update study selection "grep" pattern in tests causing CRAN ISSUE

* add test for path in setSimulationPath() + test + cleaning vignette

* update docs to put values returned + some cleaning references to private function with (:::)

* Fix bad usage of options("warn")

* delete references to .GlobalEnv in test environment

* readAntares() updated to delete `assign` function to modifiy the .GlobalEnv

* delete assign() function and ref to .GlobalEnv

* update cran-comment

* setSimulationPath() delete `getwd()` to choose dir in windows (cran policie)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants