Crashdown rails 5.2 #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The db_enhancements rake task is great, but the GRANT usage command is important to ensuring that the shared_extensions schema is available. Without this, the extensions created in this space will not be available in tenant schemas.
This changes skipping the initialization logic to exclude initializing of `assets:clean` and `assets:precompile`. This is an issue occurring when deploying to heroku where apartment attempts to connect to the database when it is not available and causes an error to occur. Fixes influitive#346
…s-clean-initialization Skip initialization of Apartment during assets:clean
[DOCS] middleware considerations and general cleanup
Fix for AbstractAdapter's DB name escaping in drop_command
When the gem is initialised and a schema adapter is being used, the adapter will initialise the schema_search_path which involves touching the database, and thus checking out a connection for the current thread. For threaded web servers, it is not expected that the main thread has a database connection, so you typically set the connection pool size equal to the number of web server threads. This patch checks the connection back in to the pool after init so that a web server thread can pick it up and use it.
…ion-during-init Don't retain connection used during gem initialisation
Accept DB config
* Use public_suffix for smarter subdomain parsing * Check validity of domain and add tests for localhost and IP * Remove unnecessary TLD length test
…methods Removing deprecated methods.
Add Rails ~5.0.0 to travis and remove ~3.2.0
…are_error Fix error on Rails 5.1.x when passing strings to the middleware stack
When use_schemas = false, switching databases would always disable query cache. Even if it was previously enabled. connect_to_new method was changed to check the current configuration and keep it after the new connection is established.
Keep query cache config after switching databases
to connect server on docker container.
capybara (the development dependency) depends on xpath, and xpath depends on nokogiri.
[ci skip] We could not reach to the bitdeli.com currently.
Test against Rails 5.2
mysql2 gem has a breaking change. https://github.com/brianmario/mysql2/releases/tag/0.5.0
Pin mysql2 version in gemfiles
gemfiles/* should be generated by `appraisal install`
Substitute tenant name in pg dump
Stop supporting for JRuby + Rails 5.0
Test against Rails 5.2
Fix exception when main database don't exist
Printing an Error message is a little bit annoying until invoke db:create.
Swallow the AR::NoDatabaseError without printing an error message
Relax mysql2 versions in some gemfiles
Prepare release for v2.2.0
Version 2.2.0 * tag 'v2.2.0': (90 commits) Prepare release for v2.2.0 $ appraisal install Remove pinning for mysql2 Appraisals: rails ~> 5.1.0 Swallow the AR::NoDatabaseError Use guard clause $ appraisal install Appraisals: Use rails 5.2.0 Drop support for JRuby + Rails 5.0 Properly namespace ar_internal_metadata dump Bump postgres version in Jenkins Preserve search path during pg tenant creation $ appraisal install gemfiles/* should be generated by `appraisal install` Pin mysql2 version in gemfiles Add note to initializer template Substitute tenant name in pg dump Fix typo Remove redundant parens Skip tests for compatibility ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been a while since I did this, and I should have opened a PR then, but I believe what I did was start with our crashdown-rails-5 branch and merge the v2.2.0 tag from influitive's repo.