-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Master to Develop Sync #107
Open
Mukulsingh27
wants to merge
113
commits into
develop
Choose a base branch
from
branch-sync
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update tested upto to 5.7
See WordPress.org SVN lint error: svn: E165001: Commit blocked by pre-commit hook (exit code 1) with output: PHP error in: login-with-google/tags/1.0.11/vendor/symfony/polyfill-intl-idn/bootstrap80.php: Parse error: syntax error, unexpected '|', expecting '{' in Standard input code on line 124 Errors parsing Standard input code
Ensure that the passed state is received. Also, check for provider to ensure that google plugin needs to handle returned response
[Fix] Verify state on round trip
[Bug-Fix] Compare expected state with received state
… into fix/oauth-class
Improve redability in readme for WP plugin page
Fix code coverage report URL
One tap login for friction-less sign in
Provide filter for client arguments: rtcamp.google_client_args
Update Readme.txt file
When user logged-in with Google and redirect to same page where shortcode displayed then still page served from page cache which causing issue. So setting cookie with prefix for that page only will bypass page cache. prefix used by most of the platform like Cloudflare
Set cookie when login with google shortcode display to bypass page cache
Code coverage report: https://gh-reports.rt.gw/login-with-google/refs/pull/107/merge/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.