Merge pull request ampproject#7605 from ampproject/bump/nodejs

Bump NodeJS from 14 to 18

.eslintrc.js

@@ -1,3 +1,11 @@
+/**
+ * WordPress dependencies
+ */
+const jsdocConfig = require('@wordpress/eslint-plugin/configs/jsdoc');
+
+// Extend jsdoc defined types.
+jsdocConfig.rules['jsdoc/no-undefined-types'][1].definedTypes.push('Backbone');
+
 module.exports = {
  root: true,
  extends: [
@@ -90,6 +98,8 @@ module.exports = {
  },
  ],
  'jsdoc/check-indentation': 'error',
+ 'jsdoc/no-undefined-types':
+ jsdocConfig.rules['jsdoc/no-undefined-types'],
  '@wordpress/dependency-group': 'error',
  '@wordpress/react-no-unsafe-timeout': 'error',
  },
@@ -115,6 +125,9 @@ module.exports = {
  'jest/prefer-inline-snapshots': 'off',
  'jest/prefer-snapshot-hint': 'off',
  'jest/no-untyped-mock-factory': 'off',
+ // Disabling because we are not using typescript.
+ // @see <https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/unbound-method.md>
+ 'jest/unbound-method': 'off',
  },
  },
  {
@@ -134,6 +147,7 @@ module.exports = {
  'jest/no-hooks': 'off',
  'jest/prefer-expect-assertions': 'off',
  'jest/prefer-inline-snapshots': 'off',
+ 'jest/unbound-method': 'off',
  },
  },
  {

.github/workflows/build-test-measure.yml

@@ -365,14 +365,6 @@ jobs:
  env:
  COMPOSE_INTERACTIVE_NO_CLI: true
 
-
- # TODO: Remove it once node version in .nvmrc is updated to >=16.
- - name: Setup Node
- uses: actions/[email protected]
- with:
- node-version: 16
- cache: npm
-
  - name: Run E2E tests
  run: npm run test:e2e:ci
 

.nvmrc

@@ -1 +1 @@
-14
+18

assets/src/block-editor/components/with-media-library-notice.js

@@ -104,7 +104,7 @@ export default (InitialMediaUpload, minImageDimensions) => {
  'toolbar:create:featured-image',
  function (toolbar) {
  /**
- * @this wp.media.view.MediaFrame.Select
+ * @this {wp.media.view.MediaFrame.Select}
  */
  this.createSelectToolbar(toolbar, {
  text: wp.media.view.l10n.setFeaturedImage,

assets/src/common/components/select-media-frame.js

@@ -227,7 +227,7 @@ export const getSelectMediaFrame = (ToolbarSelect) => {
  *
  * @param {Object} toolbar
  * @param {Object} [options={}]
- * @this wp.media.controller.Region
+ * @this {wp.media.controller.Region}
  */
  createSelectToolbar(toolbar, options) {
  options = options || this.options.button || {};

bin/local-env/install-wordpress.sh

@@ -19,7 +19,7 @@ HOST_PORT=$(dc port $CONTAINER 80 | awk -F : '{printf $2}')
 
 # Wait until the WordPress site is responding to requests.
 echo -en $(status_message "Attempting to connect to WordPress...")
-until $(curl -L http://localhost:$HOST_PORT -so - 2>&1 | grep -q "WordPress"); do
+until $(curl -L http://127.0.0.1:$HOST_PORT -so - 2>&1 | grep -q "WordPress"); do
  echo -n '.'
  sleep 5
 done
@@ -52,7 +52,7 @@ fi
 
 # Install WordPress.
 echo -e $(status_message "Installing WordPress...")
-wp core install --title="$SITE_TITLE" --admin_user=admin --admin_password=password [email protected] --skip-email --url=http://localhost:$HOST_PORT --quiet
+wp core install --title="$SITE_TITLE" --admin_user=admin --admin_password=password [email protected] --skip-email --url=http://127.0.0.1:$HOST_PORT --quiet
 
 # Create additional users.
 echo -e $(status_message "Creating additional users...")
@@ -92,9 +92,9 @@ fi
 # If the 'wordpress' volume wasn't during the down/up earlier, but the post port has changed, we need to update it.
 echo -e $(status_message "Checking the site's url...")
 CURRENT_URL=$(wp option get siteurl)
-if [ "$CURRENT_URL" != "http://localhost:$HOST_PORT" ]; then
- wp option update home "http://localhost:$HOST_PORT" --quiet
- wp option update siteurl "http://localhost:$HOST_PORT" --quiet
+if [ "$CURRENT_URL" != "http://127.0.0.1:$HOST_PORT" ]; then
+ wp option update home "http://127.0.0.1:$HOST_PORT" --quiet
+ wp option update siteurl "http://127.0.0.1:$HOST_PORT" --quiet
 fi
 
 # Install a dummy favicon to avoid 404 errors.