feat: Allow excluding the Github Actor from the message #112
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
There is currently no way to exclude the Github Actor from being in the message.
Solution
According to the Slack API documentation, the
author_link
andauthor_icon
values only work ifauthor_name
is present.With
omitempty
specified on theauthor_name
within theAttachment
structure, allowingSLACK_MSG_AUTHOR
to be an empty string will result in this field being unset which will allow users to choose if they want to exclude the Github Actor from being in the message.Changes
main.sh
to use=
instead of:-
on setting theGITHUB_ACTOR
which avoids empty strings being substitutedREADME.md
with details on how to avoid including the Github Actor in the message