Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some profile fixes #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

some profile fixes #1

wants to merge 1 commit into from

Conversation

secretpray
Copy link

Some fixes

secretpray
secretpray commented Mar 7, 2024
View reviewed changes
app/helpers/profile_helper.rb
@@ -0,0 +1,13 @@
# frozen_string_literal: true
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe move in decorator?

@rt4914
Copy link
Owner

rt4914 commented Mar 7, 2024

Really appreciate this PR @secretpray
These changes to make sense and I will definitely incorporate these changes in the code. I might do this at a later stage because I know that there are actually many ways in which we can improve the code but right now I am sticking to basic CRUD operations. Rest assured your efforts will get incorporated to benefit the community at large.

Again, Thanks a lot as always :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@secretpray @rt4914