Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added pathologyImageRGB to REFERENCE.md. #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added pathologyImageRGB to REFERENCE.md. #4

wants to merge 1 commit into from

Conversation

sarachan
Copy link
Contributor

@sarachan sarachan commented Feb 6, 2018

No description provided.

millerjv
millerjv reviewed Feb 6, 2018
View reviewed changes
Copy link
Contributor

@millerjv millerjv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we using "cellType" to pick the protocol to talk to the datastore (tif://) ? Why does a cell care what type of image is displayed?

@sarachan
Copy link
Contributor Author

sarachan commented Feb 6, 2018

It has been the approach for quite some time that cellType would be 'image' or 'pathologyImage'. I have extended this to alternately be 'pathologyImageRGB'. I agree we are using cellType to describe the image format.

@millerjv
Copy link
Contributor

millerjv commented Feb 6, 2018

Let's revisit cellType and how/if we need to specify a subtype.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millerjv millerjv millerjv left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sarachan @millerjv