Code changes to imageViewers.js and dynamicDisplayService.js to enabl… #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e RGB tiff images to be displayed.
|
Jim, I have entered pull requests to three repos to enable display of RGB TIFF images: rt106-frontend, rt106-datastore-local, rt106.github.io. These should be considered together, and accepted / rejected as a unit. Thanks, |
millerjv
reviewed
Feb 6, 2018
There was a problem hiding this comment.
I don't think I like the "cellType" concept as it is being used - image, pathologyImage, pathologyImageRGB. It feels like the wrong abstraction. I like cellType when mapped to image, table, plot, .. concept. If we need additional subtypes on image, perhaps we can use:
image, image-dicom, image-monochome, image-color? Not sure about his either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e RGB tiff images to be displayed.