Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild of rsyslog to add pmnormalize subpackage on bionic and xenial #84

Merged
merged 1 commit into from
Feb 8, 2019

Conversation

julthomas
Copy link
Contributor

Hello,
Sorry but I am not familiar with debian package builds, let me know if something is wrong or missing. In particular I am not sure at all about the v8-stable-testing or master trees, nor the changelog files (maybe it is autogenerated by your build system?).
This goes along with rsyslog/rsyslog-pkg-rhel-centos#50
I could not test this!
Julien

@friedl
Copy link
Contributor

friedl commented Nov 5, 2018

For Ubuntu packages we require:

  • correct entry in rules file to enable on configure
  • correct entry in control file for the package details and possible dependencies
  • xxx.install file

The changelog entries for the release packages will be written by hand when generating the packages, so changes to this file are not needed.

The definitions for master tree should be added as well.

The v8-stable-testing branch will be updated from v8-stable when required since these are only for testing the package build and are not intended in productive use, so changes here are not needed at all

If you can update the PR, I can later merge and rebuild.

@julthomas
Copy link
Contributor Author

Hello @friedl, OK thanks, I will update. I'd like also to see imdiag packaged, would that be acceptable? If so, do you prefer a separate PR or is it OK with 2 distinct commits is the same PR? Same for EL packages.

@julthomas
Copy link
Contributor Author

Hello @friedl, I have updated the pull request.
Regards, Julien

@friedl friedl merged commit 667b8a6 into rsyslog:master Feb 8, 2019
@friedl
Copy link
Contributor

friedl commented Feb 8, 2019

Hi Julien,
your PR has been merged and the packages have been rebuilt. Sorry for the delay.
Florian

friedl added a commit that referenced this pull request Feb 8, 2019
  * Removed dependency for liblogging-stdlog. Ref: https://github.com/rsyslog/rsyslog-pkg-ubuntu/is$
  * Added sub-package for pmnormalize. Ref: #84
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants