ensure we use newest docker image when building #4
Conversation
| @@ -9,6 +9,7 @@ if [ "$RSA_PRIVATE_KEY" == "" ]; then | |||
| fi | |||
| echo PWD: $PWD | |||
| echo HOME: $HOME | |||
| docker pull rsyslog/docker-alpine-abuild:3.7 # be on the save side... | |||
There was a problem hiding this comment.
Thoughts:
- Update the FROM line in your Dockerfile to reflect the latest stable upstream image:
-FROM alpine:3.7
+FROM alpine:latestWhenever you build your image the Dockerfile would use the latest upstream stable image.
- Either explicitly tag (or allow the default to apply) your new docker image with 'latest'.
Now when you call the docker run command, you could either explicitly specify that tag or allow docker to default to using that tag when fetching the image.
There was a problem hiding this comment.
We need to be careful here. When 3.8 comes out, we still must support the 3.7 packages, and they can be different. For that reason, we need to nail the build to specific versions. The idea is to support all version also currently supported by Alpine. Right now that would be 3.6 and 3.7, but as 3.8 will come out soon, I am not digging into 3.6.
There was a problem hiding this comment.
some comment applies to the actual packaging content, not just the helper container
There was a problem hiding this comment.
Gotcha. Carry on then, ignore my chattering. ;)
No description provided.