Update Checkpoint parser #325
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, |
|
Also, have a look at #234 as it is meant to fix the no quotes support so that we do not try to fix it in different ways |
Hello, |
|
Top go forward, the CI failures must be fixed. I guess they indicate a backwards.-incompatible changed happened. |
As of today, Checkpoint logs do not necessarily provide a semicolon between the last key:value pair and the terminator. This causes the parse to fail with current behavior.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Checkpoint parser to parse newest format with quoted strings, for example :
[action:"Accept"; dst:"192.168.1.2"; product:"FireWall"; src:"192.168.1.3"; ]