Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "hidden-xs" class to logo … #310

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DivadNojnarg
Copy link

Consider the following example with the current version of shinydashboard, on a cellphone for instance:

library(shiny)
library(shinydashboard)
shinyApp(
  ui = dashboardPage(
    dashboardHeader(),
    dashboardSidebar(),
    dashboardBody(),
    title = "Dashboard example"
  ),
  server = function(input, output) { }
)

capture d ecran 2019-02-12 a 08 56 05

We have a blue bar above the sidebar trigger taking unnecessary vertical space.

This simple PR aims at adding the extra class "hidden-xs" to "logo", so that it is not displayed on small screen devices when the title is NULL in dashboardheader (even though it is better to give a title):

span(class = if (is.null(title)) "logo hidden-xs" else "logo", title)

@DivadNojnarg
Copy link
Author

On the AppVeyor build, I see installation of package 'later' had non-zero exit status

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants