-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add collapsible sidebar which is capable of showing only icons #133
base: main
Are you sure you want to change the base?
Conversation
@@ -117,7 +117,7 @@ dashboardSidebar <- function(..., disable = FALSE, width = NULL) { | |||
custom_css, | |||
tags$section( | |||
class = "sidebar", | |||
`data-disable` = if(disable) 1 else NULL, | |||
`data-disable` = if(disable) TRUE else NULL, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC, this should be a 1
because that's what's expected by AdminLTE. Also, TRUE
is not particularly meaningful in HTML. For example,
> tags$section(`foo`=TRUE)
<section foo="TRUE"></section>
I think this sort of thing should be implemented as an option to |
move them to dashboardSidebar delete spaces
Hi @wch , Thank you for the review. I have now updated code and it works as I would like to see it working (main functionality is there now). |
…Per email request of @jackolney
CC' @jackolney @wch |
Hello, I am trying for 3 days without success to implement the "collapsible sidebar which is capable of showing only icons". I don't understant how the links are made between the different R files and those present in the "inst" folder. Is it possible to explain me ? Thank you in advance ! |
Hello, Please consider detule@afecd74 for an alternative solution, one that toggles this feature as an option to dashboardSidebar. |
|
Addresses: #74 and #79