Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PYTHON_VERSION_JUPYTER to match PYTHON_VERSION_ALT #615

Merged
merged 2 commits into from
Aug 9, 2023
Merged

Update PYTHON_VERSION_JUPYTER to match PYTHON_VERSION_ALT #615

merged 2 commits into from
Aug 9, 2023

Conversation

bschwedler
Copy link
Contributor

@bschwedler bschwedler commented Aug 9, 2023 •
edited by ianpittwood
Loading

Closes #613

The current just automation to update python versions does not
currently apply to PYTHON_VERSION_JUPYTER.

@bschwedler bschwedler requested a review from cm421 as a code owner August 9, 2023 15:30
@bschwedler bschwedler added bug Something isn't working customer request Requested by customer labels Aug 9, 2023
@ianpittwood
Copy link
Collaborator

I also made #614 to hopefully replace this PYTHON_VERSION_JUPYTER convention globally. Right now, I don't think it's a value add for us in any way I can perceive.

@bschwedler
Update PYTHON_VERSION_JUPYTER to match PYTHON_VERSION_ALT
9f6f8b2 
Closes #613

The current `just` automation to update python versions does not
currently apply to `PYTHON_VERSION_JUPYTER`.

This is a one-off fix until we address this fully in #590
@bschwedler bschwedler merged commit 99b918a into dev Aug 9, 2023
88 checks passed
@bschwedler bschwedler deleted the fix-python-verison-jupyter branch August 9, 2023 18:21
@ianpittwood ianpittwood mentioned this pull request Aug 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianpittwood ianpittwood ianpittwood approved these changes

@cm421 cm421 Awaiting requested review from cm421 cm421 is a code owner

@melissa-barca melissa-barca Awaiting requested review from melissa-barca melissa-barca is a code owner

Assignees
No one assigned
Labels
bug Something isn't working customer request Requested by customer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unable to build workbench/Dockerfile.ubuntu2204
2 participants
@bschwedler @ianpittwood